Repository navigation
fix: 修复为我推荐页面点击MV直接展示评论区而不是mv本身的bug - #649
Conversation
Summary of ChangesHello @flystar233, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求旨在解决一个用户体验问题，即在导航到MV页面时，用户可能会发现页面滚动到了底部，直接显示评论区而非MV内容。通过在路由导航完成后智能地重置主内容区域的滚动位置，确保了用户在访问新MV时总是从页面顶部开始浏览，从而提升了用户体验。 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| if (to.path !== from.path || to.query.id !== from.query.id) { | ||
| const mainContent = document.getElementById("main-content"); | ||
| if (mainContent) { | ||
| const scrollContainer = mainContent.querySelector(".n-scrollbar-container"); | ||
| if (scrollContainer) scrollContainer.scrollTop = 0; | ||
| } | ||
| } |
There was a problem hiding this comment.
目前的判断条件 to.path !== from.path || to.query.id !== from.query.id 只检查了路径和 id 查询参数的变化。这对于修复 MV 页面的 bug 是有效的，但对于其他使用不同查询参数的页面（例如使用 keyword 的搜索页）则无效。
为了使逻辑更通用，建议修改判断条件，以覆盖所有路径或查询参数变化的情况，同时忽略仅哈希值（hash）的变化。
一个更健壮的方法是比较 fullPath 中除去哈希值的部分。这样可以正确处理所有页面导航，使代码更具可维护性。
| if (to.path !== from.path || to.query.id !== from.query.id) { | |
| const mainContent = document.getElementById("main-content"); | |
| if (mainContent) { | |
| const scrollContainer = mainContent.querySelector(".n-scrollbar-container"); | |
| if (scrollContainer) scrollContainer.scrollTop = 0; | |
| } | |
| } | |
| if (to.fullPath.split("#")[0] !== from.fullPath.split("#")[0]) { | |
| const mainContent = document.getElementById("main-content"); | |
| if (mainContent) { | |
| const scrollContainer = mainContent.querySelector(".n-scrollbar-container"); | |
| if (scrollContainer) scrollContainer.scrollTop = 0; | |
| } | |
| } |
|
update by gemini-code-assist |
flystar233
changed the title
2 participants
No description provided.