This repository was archived by the owner on Jul 17, 2026. It is now read-only.
Repository navigation
feat(lyric): 优化歌词排除 - #514
Merged
Merged
Conversation
Collaborator
Author
MoYingJi
marked this pull request as ready for review
October 24, 2025 10:41
Collaborator
Author
|
现在有个很奇怪的 BUG，重启程序或者热重载后的第一次歌词解析时，TTML 歌词必定也会被排除 不受设置影响🤔 |
Collaborator
Author
BUG 原因：投机取巧的两个人 
|
Contributor
|
自从我通过PR加入ttml格式歌词功能后, 你的代码贡献挺勤奋的 |
Contributor
Collaborator
Author
因为加入这个功能之后体验要好不少，使用强度也更高，因此能发现更多的问题，也更愿意贡献 之前我还不会 TypeScript/Vue/Electron，最近我在研究 VitePress (部署在我的 GitHub Pages)，所以也会了一小点的 TypeScript 和 Vue，仿照这个项目原来的代码就能写写了 |
imsyy
approved these changes
Oct 24, 2025
Collaborator
Author
|
奇怪，开发环境没问题，为啥一编译出来就报错一堆 🤔
|
Member
|
没事，这是 store 的报错，试试清除下缓存 |
Collaborator
Author
|
程序的设置里好像没有清除缓存的选项 |
Member
可以在控制台的这里删除 |
Collaborator
Author
|
好的 谢谢 问题解决了 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
此 PR 已经编辑完成
主要变动：
excludeRegexes设置项，同时增加getExcludeRegexes函数isLyricExcluded函数，并将所有排除歌词的逻辑替换为此函数ExcludeKeywords改名为ExcludeLyricsExcludeLyrics中编辑excludeRegexes设置项enableExcludeTTML设置项enableExcludeLocalLyrics设置项isLyricExcluded的函数增加skipExclude参数，调用这些函数的时候必须先判断enableExcludeTTML和enableExcludeLocalLyrics并以此传入skipExclude参数