"git bug push" fails with "Error: repository not found" when using insteadOf #944

Activity

1. MichaelMure

   added

   area/dependenciesRelates to dependenciesRelates to dependencies

   go-git

   kind/bugRelates to an issueRelates to an issue

   on Dec 8, 2022
2. MichaelMure commented on Dec 8, 2022

   

   MichaelMure

   on Dec 8, 2022

   Contributor

   More actions

   It's likely another shortcoming of go-git, although it seems that support for that has been added? go-git/go-git#79

   Unfortunately, it's unlikely I can do anything about it. Maybe try to see if go-git (the minimal command they have) is able to understand your config?
3. larsks commented on Dec 9, 2022

   

   larsks

   on Dec 9, 2022

   Last edited by larsks

   Author

   More actions

   Stepping through things with dlv debug, it looks like go-git isn't reading the global configuration: if I move the url configuration into .git/config, it seems to work as expected. That is, with the url configuration only in the global config, c.URLS is empty when we get to https://github.com/go-git/go-git/blob/master/config/config.go#L338; if I put the url configuration into .git/config, that variable gets populated as expected and insteadOf aliases are expanded.

   The weird thing is that running git-bug under strace I can see that it's clearly reading the global configuration, so not entirely clear what's going on here.

   This is probably a go-git issue, but to verify that I'll have to create a reproducer.
4. MichaelMure commented on Dec 9, 2022

   

   MichaelMure

   on Dec 9, 2022

   Contributor

   More actions

   Those are two very different code path, as git-bug is reading the local+global config on its own. On the other hand when push/pull is done, it's pure go-git. It does look like a go-git bug.
5. github-actions commented on Jul 23, 2024

   

   github-actionsbot

   on Jul 23, 2024 – with GitHub Actions

   More actions

   This bot triages untriaged issues and PRs according to the following rules:

   • After 90 days of inactivity, the lifecycle/stale label is applied
   • After 30 days of inactivity since lifecycle/stale was applied, the issue is closed

   To remove the stale status, you can:

   • Remove the lifecycle/stale label
   • Comment on this issue
6. github-actions

   added

   lifecycle/stale

   on Jul 23, 2024
7. sudoforge

   removed

   go-git

   on Aug 3, 2024
8. miwig commented on Aug 6, 2024

   

   miwig

   on Aug 6, 2024

   More actions

   I got this problem with a repository URL containing ~ to refer to the home directory. Using an absolute path fixed it.
9. sudoforge

   added this to the 0.8.2 milestone on Aug 7, 2024
10. sudoforge

    self-assigned this

    on Aug 7, 2024
11. sudoforge

    added

    triage/acceptedThis issue is acceptedThis issue is accepted

    area/gitRelates to git operationsRelates to git operations

    priority/backlogHigher priority than priority/awaiting-more-evidenceHigher priority than priority/awaiting-more-evidence

    and removed

    area/dependenciesRelates to dependenciesRelates to dependencies

    lifecycle/stale

    on Aug 7, 2024
12. sudoforge commented on Aug 7, 2024

    

    sudoforge

    on Aug 7, 2024

    Last edited by sudoforge

    Contributor

    More actions

    @larsks said earlier:

    it looks like go-git isn't reading the global configuration: if I move the url configuration into .git/config, it seems to work as expected

    i know it's been a while, but thanks for running the debugger. having used go-git in some other projects, i can confirm indeed that they do not parse the url.<base>.insteadOf configuration (or even, last i checked, configuration via includeIf or other mechanisms).

    support for this was (supposedly) added in go-git/[email protected], but it doesn't seem to actually work, with the url.<base>.insteadOf configuration in either the global or local scope, for example, using the following configuration:

    [remote "origin"]
    	url = gh:git-bug/git-bug.git
    	fetch = +refs/heads/*:refs/remotes/origin/*
    
    [url "ssh://[email protected]/"]
    	insteadOf = gh:
    

    this is still an issue at HEAD (3141185). it looks like we'll need to manually account for this using the default configuration chain (local > global > system, following any includes). i've accepted this bug and have slotted it in for the 0.8.2 release.

    ---

    @miwig said earlier:

    I got this problem with a repository URL containing ~ to refer to the home directory. Using an absolute path fixed it.

    are you able to share your url.<base>.insteadOf config(s) for the remote you specified, and remote.<name>.url configuration for the repository? please be sure to redact anything you wish, such as paths on your local filesystem or details from the remote configuration that you don't want to share.
13. sudoforge

    modified the milestones: 0.8.2, 0.8.1 on Apr 29, 2025
14. github-actions

    added

    lifecycle/pinned

    on Apr 29, 2025
15. sudoforge

    added 4 commits that reference this issue on Apr 29, 2025

    fix: use the git cli to resolve remote URIs

    ...

    This issue will close once commit e742ce3 is merged into the 'trunk' branch.

    e742ce3

    fix: resolve the remote URI using url.*.insteadOf

    ...

    This issue will close once commit 973da59 is merged into the 'trunk' branch.

    973da59

    fix: resolve the remote URI using url.*.insteadOf

    ...

    This issue will close once commit f96836c is merged into the 'trunk' branch.

    f96836c

    fix: resolve the remote URI using url.*.insteadOf

    ...

    This issue will close once commit 8798018 is merged into the 'trunk' branch.

    8798018
16. sudoforge

    closed this as completedin #1394on Apr 30, 2025
17. sudoforge

    closed this as completedin a150cdbon Apr 30, 2025
18. pull

    added a commit that references this issue on Apr 30, 2025

    fix: resolve the remote URI using url.*.insteadOf (git-bug#1394)

    ...

    This issue will close once commit a150cdb is merged into the 'master' branch.

    a150cdb