Add SPM support#10
Conversation
|
@dreampiggy, could you review this one pls? 🙏 |
|
Hi. |
|
This one seems need a little changes, please have a check like the one https://github.com/SDWebImage/SDWebImagePhotosPlugin/blob/master/SDWebImagePhotosPlugin/Classes/SDWebImagePhotosDefine.h For example:
|
|
Thank you for the review; I've changed the imports and tested both against cocoapods and spm. The only thing really added besides the imports is a |
|
Does SVGKit supports watchOS ? The package.swift list the watchOS_v2 ... The podspec and Xcode seems does not add watchOS target. I remember the time when I create this repo, SVGKit does not have any watchOS. |
|
Correct, I've updated the minimum platform requirements to align with SVGKit, great catch 👍 |
|
LGTM now. |
|
Released v1.4.0 |
|
Thank you 🙌 |
This PR adds basic SPM support.
Can be tested by integrating the master branch of the forked repo. One should be able to remove a cocoapod and use the Swift Package instead without any further code changes.