Various fixes - #340
Merged
Merged
Conversation
This was referenced Jul 12, 2026
Closed
The issue was that we were storing the uniform grid by reference. However, GPU needs to deep_copy the grid.
We fix the layouts in a few places to handle fields with multiple components.
…always has classification Squashed original commits: d7daece, bb57d62
jacobmerson
force-pushed
the
jacobmerson/various-fixes
branch
from
July 13, 2026 07:11
6c13b7c to
9559d9d
Compare
Collaborator
Author
|
Looks like the PR stacking didn't work right. Looks like I may need to rebase onto develop. |
Contributor
|
Is this supposed to be merged into master now, since set-get-2d-arrays has already been merged? |
Collaborator
Author
|
Yes although |
Contributor
|
I changed the base branch to |
Collaborator
Author
|
Probably should have just targeted everything at develop to begin with that way the tests run etc. There is probably a way to make the stacking work as intended, but clearly this wasn't the way... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Layered on top of #339.