Group analysis support#358
Draft
ConnectedSystems wants to merge 14 commits intoSALib:experimental-methodsfrom
Draft
Group analysis support#358ConnectedSystems wants to merge 14 commits intoSALib:experimental-methodsfrom
ConnectedSystems wants to merge 14 commits intoSALib:experimental-methodsfrom
Conversation
Raise warning if method does not support groups
|
Hello, @ConnectedSystems. Sure, it would be great to help, but this week I'm a little too busy with my PhD thesis. I can work on this in about 1 week, if it's not too late. |
Member
Author
|
Thanks, @lbteixeira There's no deadline and so. no rush. I'll come back to this myself in a week or so as well. |
Member
|
One thing to consider with grouping approaches is that you can get cancellation effects. Morris uses an average of absolute elementary effect when computing sensitivity indices for groups, rather than the average. For example with two parameters in one group, if one parameter has a strong positive effect, and another a strong negative effect, these will cancel out when averaged and the group will seem to have a negligible effect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support analysis of parameter groups, or raise warning when they are not supported.
The method implemented just generalizes the existing approach for Morris - averaging the effect across group members.
With apologies to @lbteixeira for replacing the recently added
_compute_grouped_metric()DGSM and HDMR implementations were a little over my head so could not adjust the code to allow group analysis at this time (perhaps @sahin-abdullah or @lbteixeira would be willing to help here?).