First attempt at incorporating sampling for uniformity (Morris)#247
Open
JoerivanEngelen wants to merge 2 commits intoSALib:mainfrom
Open
First attempt at incorporating sampling for uniformity (Morris)#247JoerivanEngelen wants to merge 2 commits intoSALib:mainfrom
JoerivanEngelen wants to merge 2 commits intoSALib:mainfrom
Conversation
Contributor
Author
|
This should fix #131 |
Contributor
Author
|
I see that most of the tests now fail because no grid_jump is provided in the tests, which raises the question: why didn't they fail in previous commits? |
…ormity and moved a warning so that it would not be called Q times.
Member
The grid jump argument was removed in an earlier release, as it is was computed directly from the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the original paper, see Khare et al. 2015
A multi-criteria trajectory-based parameter sampling strategy for the screening method of elementary effects
I thought I'll leave it as a pull request here, so we can discuss the code.
I had to hack the sampling strategy quite a bit to get this one to work. Goal was to use as much of the original SALib functions as possible. Currently the variable names I chose are quite bad and the code can be quite confusing. I also had to override some of the checks.
Most confusing is that the RepeatedSampling class inherits the Strategy class with:
num_pars=sampling4uniformityand
k_choice=num_parsFor this to be more understandable, probably the original code has to be refactored a bit.
You can try it out yourself with for example:
Here sample4uniformity sets what is "Q" in the paper, the number of repeated sampled trajectories.
To do: