Repository navigation
Synchronize mmap cursor updates and sequence bytes - #9448
Merged
Merged
Conversation
Extract mmap cursor and sequence behavior plus its whole canonical free-threading test from RustPython#9439. Regenerate the test with scripts/update_lib from CPython d220409a13b77de7a6c30abe16ea90db01528edc. Assisted-by: OpenAI Codex: model version unavailable
Contributor
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
📦 Library DependenciesThe following Lib/ modules were modified. Here are their dependencies: [ ] test: cpython/Lib/test/test_free_threading dependencies: dependent tests: (no tests depend on free_threading) Legend:
|
youknowone
approved these changes
Oct 29, 2026
youknowone
marked this pull request as ready for review
October 29, 2026 04:41
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep mmap cursor reads/updates under the mapping guard and preserve the byte-string result of sequence iteration. Includes the whole canonical mmap free-threading test file.
This is a functionality-based extraction from #9439, based on main
84d7afc2d59e05c66c92df3ce0854679d2b32b52. The original aggregate is being narrowed to monitoring. The extracted files are preserved exactly from the reviewed aggregate source.All included Lib files were regenerated with actual
scripts/update_lib migratefrom CPythond220409a13b77de7a6c30abe16ea90db01528edcand match that pin byte-for-byte. No test file is split across PRs and no assertions or skips are added.Validation and limits
Earlier aggregate: 30 bounded serial anonymous-mmap checks are historical evidence from a different combined executable. No new local mmap concurrency, resize/flush race or crash test was run.
Fresh standalone
cargo check -p rustpython-stdlib --lib --no-default-features --features compiler,threading,host_env,doc,ucd_3_2_0and matching strict Clippy (-D warnings) passed on the 84d7 base, with locked/offline dependencies and source hashes verified before and after. No runtime test was run for this extraction. Exact-head hosted CI: pending. Old aggregate green checks are historical, not standalone validation of this extraction.