Repository navigation
Serialize host syslog mask changes - #9447
Conversation
Extract the syslog lock and whole canonical free-threading test from RustPython#9439. Regenerate the test with scripts/update_lib from CPython d220409a13b77de7a6c30abe16ea90db01528edc. Assisted-by: OpenAI Codex: model version unavailable
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📦 Library DependenciesThe following Lib/ modules were modified. Here are their dependencies: [ ] test: cpython/Lib/test/test_free_threading dependencies: dependent tests: (no tests depend on free_threading) Legend:
|
Merging this PR will not alter performance
Comparing 
Footnotes
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
Serialize libc setlogmask calls with one shared native mutex. Includes the whole canonical syslog free-threading test file.
This is a functionality-based extraction from #9439, based on main
84d7afc2d59e05c66c92df3ce0854679d2b32b52. The original aggregate is being narrowed to monitoring. The extracted files are preserved exactly from the reviewed aggregate source.All included Lib files were regenerated with actual
scripts/update_lib migratefrom CPythond220409a13b77de7a6c30abe16ea90db01528edcand match that pin byte-for-byte. No test file is split across PRs and no assertions or skips are added.Validation and limits
No local syslog calls or process-mask changes were performed. The canonical hosted test remains required for actual behavior.
Fresh standalone
cargo check -p rustpython-host_env --lib --no-default-featuresand matching strict Clippy (-D warnings) passed on the 84d7 base, with locked/offline dependencies and source hashes verified before and after. No runtime test was run for this extraction. Exact-head hosted CI: pending. Old aggregate green checks are historical, not standalone validation of this extraction.