Skip to content

Update remaining free-threading library tests for Python 3.15 - #9446

Merged
youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:split/9439-pure-lib-20261029
Oct 29, 2026
Merged

Update remaining free-threading library tests for Python 3.15#9446
youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:split/9439-pure-lib-20261029

Conversation

@youknowdot

@youknowdot youknowdot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Extract six whole canonical modules from #9439: cprofile, io, iteration, json, sqlite3 and str. There are no Rust changes.

This is a functionality-based extraction from #9439, based on main 84d7afc2d59e05c66c92df3ce0854679d2b32b52. The original aggregate is being narrowed to monitoring. The extracted files are preserved exactly from the reviewed aggregate source.

All included Lib files were regenerated with actual scripts/update_lib migrate from CPython d220409a13b77de7a6c30abe16ea90db01528edc and match that pin byte-for-byte. No test file is split across PRs and no assertions or skips are added.

Validation and limits

Canonical byte comparison, exact six-file diff, git diff --check and source/import review completed. No local concurrency, profiler or crash tests. Main already contains the JSON list-index and interned-state prerequisites, but source import availability does not prove concurrent behavior. JSON/str/sqlite3 dictionary mutation and cProfile still need this branch’s own hosted results.

No new native compile is applicable to this Lib-only diff. Exact-head hosted CI: pending. Old aggregate green checks are historical, not standalone validation of this extraction.

@codex
Update remaining free-threading library tests for Python 3.15
ad344a4 
Extract the six canonical library-only modules from RustPython#9439. Regenerated with scripts/update_lib from CPython d220409a13b77de7a6c30abe16ea90db01528edc.

Assisted-by: OpenAI Codex: model version unavailable
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 6
  • Lib/test/test_free_threading/test_cprofile.py is excluded by !Lib/**
  • Lib/test/test_free_threading/test_io.py is excluded by !Lib/**
  • Lib/test/test_free_threading/test_iteration.py is excluded by !Lib/**
  • Lib/test/test_free_threading/test_json.py is excluded by !Lib/**
  • Lib/test/test_free_threading/test_sqlite3.py is excluded by !Lib/**
  • Lib/test/test_free_threading/test_str.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@youknowdot youknowdot mentioned this pull request Oct 29, 2026
Draft
@github-actions

github-actions Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[ ] test: cpython/Lib/test/test_free_threading

dependencies:

dependent tests: (no tests depend on free_threading)

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated

@codspeed

codspeed Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 4 skipped benchmarks1

Comparing youknowdot:split/9439-pure-lib-20261029 (ad344a4) with main (84d7afc)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@youknowone
youknowone marked this pull request as ready for review October 29, 2026 04:35
@youknowone
youknowone merged commit 39a7388 into RustPython:main Oct 29, 2026
22 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-29T04:36:30.142414Z
We couldn’t complete this review. Comment @codex review to try again.		 ad344a4 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

3 participants

@youknowdot @youknowone @codex