Skip to content

Update Lib set, type, and resource concurrency tests to Python 3.15 - #9435

Merged
youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:youknowdot/free-threading-types-315-20261028
Oct 29, 2026
Merged

youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:youknowdot/free-threading-types-315-20261028

Conversation

@youknowdot

Copy link
Copy Markdown
Contributor

Summary

Sync three previously missing Python 3.15 canonical free-threading suites: set operations, type mutation/cache behavior, and read-only resource accounting.

All three files were migrated with scripts/update_lib migrate from CPython d220409a13b77de7a6c30abe16ea90db01528edc and are byte-identical. This adds 468 lines with 14 test method definitions (approximately 17 cases including inherited set cases; static count, not runtime discovery). No new markers, assertion changes, native changes, or duplicated package initializer.

Validation and limits

  • Updater unit tests: 228 passed. Applicable configured hooks and diff checks passed.
  • Native API, container-reference lifetime, and type-lock/cache paths were source-reviewed. No local concurrency tests or native build were run; hosted CI must establish runtime results.
  • RustPython passes the package GIL-disabled gate; existing threading and platform capability gates still apply.
  • Set tests use up to 11 workers. Several workers terminate only after another worker successfully sets an event; two-second barriers and direct joins can fail or strand workers if those paths fail.
  • Type tests cover cache monotonicity, class/base/name updates, and special-method propagation to 100 subclasses. The seven-thread regression has six variable-work actors until 200 base changes complete, so allocation/work is scheduling-dependent. The first cache test does not read submitted future results; it is not strong worker-exception coverage.
  • Resource coverage is read-only: 10 workers each perform 1,000 empty iterations and two getrusage calls, followed by one process-level call. No resource limits are changed. Canonical feature gates and timing/accounting inequalities are retained unchanged.
  • Existing CI's 600-second test timeout provides outer containment, not a deadlock-freedom or general CPython concurrency-equivalence guarantee.

The known native prerequisites for other missing suites remain separate; this PR does not add skip-only unsupported fixture families.

Sync unchanged canonical tests with existing threading and platform gates.

Assisted-by: OpenAI Codex: model version unavailable
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 3
  • Lib/test/test_free_threading/test_resource.py is excluded by !Lib/**
  • Lib/test/test_free_threading/test_set.py is excluded by !Lib/**
  • Lib/test/test_free_threading/test_type.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@youknowone
youknowone marked this pull request as ready for review October 28, 2026 14:22
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-28T14:23:56.937592Z
We couldn’t complete this review. Comment @codex review to try again.
336c66b Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[ ] test: cpython/Lib/test/test_free_threading

dependencies:

dependent tests: (no tests depend on free_threading)

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated

@youknowone
youknowone merged commit bbbdcf0 into RustPython:main Oct 29, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants