Fix ctypes subclass bitfields and native type metadata - #9395

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Recent review info

Run configuration

• Source mode: Auto
• Repository: RustPython/RustPython
• Branch: main
• File: .coderabbit.yml
• Commit: b811715
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 7476e501-ce4d-451f-b16c-8c56d5fc9836

Commits

Reviewing files that changed from the base of the PR and between b811715 and 2bb1026.

Files selected for processing: 3

• crates/vm/src/stdlib/_ctypes/base.rs
• crates/vm/src/stdlib/_ctypes/function.rs
• extra_tests/snippets/stdlib_ctypes.py

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

ctypes argument and return handling now uses initialized type metadata instead of the mutable _type_ attribute. Bitfield reads use the extraction path only for scalar-returning fields. New tests cover mutated scalar subclass metadata, pointer casting, and bitfield access.

Changes: ctypes conversion and field access

Layer / File(s)	Summary
Native conversion and pointer checks crates/vm/src/stdlib/_ctypes/function.rs, extra_tests/snippets/stdlib_ctypes.py	Argument validation, pointer casting, return handling, and py_object result detection use stored type metadata. Tests check native-call conversion and pointer casting after _type_ changes.
Bitfield subclass access crates/vm/src/stdlib/_ctypes/base.rs, extra_tests/snippets/stdlib_ctypes.py	Bitfield extraction applies when the field returns a scalar. Tests check access to a MutableInt bitfield. A comment notes that c_bool writes the whole byte for bitfields; setter logic is unchanged.

Priority: Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Possibly related PRs

• RustPython/RustPython#9390: Changes ctypes scalar metadata, bitfield access, and native conversion; this PR addresses related scalar-subclass cases.
• RustPython/RustPython#9229: Introduces storage-backed ctypes views and initialized scalar metadata used by these changes.
• RustPython/RustPython#9251: Introduces initialized scalar codes and storage-backed scalar field handling extended here.

Suggested reviewers: youknowone

Merge Risk: Minimal · up to 2bb10

The reviewed changes have no established merge-blocking issue; they are ready for normal checks.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 3 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main changes: fixing ctypes subclass bitfields and using native type metadata.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

🧪 Generate unit tests (beta)

• Create a new PR

• X
• Mastodon
• Reddit
• LinkedIn