Skip to content

Cut redundant CI work - #9371

Merged
youknowone merged 3 commits into
RustPython:mainfrom
moreal:ci/snippets-cpython-ubuntu-only
Oct 26, 2026
Merged

youknowone merged 3 commits into
RustPython:mainfrom
moreal:ci/snippets-cpython-ubuntu-only

Conversation

@moreal

@moreal moreal commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

One of checkbox below must be checked.

  • I did not use AI to write the code of this patch.
  • This PR follows our AI policy

Summary

Cuts redundant CI work without adding jobs.

  • cargo doc --no-deps.
  • The example projects share one target directory.
  • One macOS runner checks both macOS cross targets. The two cargo check (macos-latest, …) checks become one; update branch protection if they are required.

Measured on the same base commit, main vs this PR, for steps that did not restore a cache in either run:

Step main This PR
cargo doc 7.5 min 4.8 min
Build example projects 3.9 min 2.9 min
macOS cargo check 2 runners, 8.1 + 7.2 min 1 runner, 8.9 min

AI assistance

Claude Code wrote all of this PR: the investigation of CI timings, every commit, and this description, at the PR author's direction. It verified the changes with actionlint and zizmor and with cargo unit graphs of the example and macOS check builds; the changes were verified on macOS and Windows only by this PR's CI runs.

🤖 Generated with Claude Code

cargo doc ran rustdoc on every dependency as well; in run RustPython#91 that was
284 documented crates for a check of this workspace's own docs.

Assisted-by: Claude Code
Claude-Session: https://claude.ai/code/session_01JpHqXiC3mDShqfsPxvr9ey
Each example project is its own workspace and built into its own target
directory, so the second build recompiled the dependencies the first had
just built. Of the 359 units the frozen_stdlib build needs, 261 are
identical to units of the barebone build.

Assisted-by: Claude Code
Claude-Session: https://claude.ai/code/session_01JpHqXiC3mDShqfsPxvr9ey
macOS runners have the smallest concurrent-job limit of the hosted
runners. The aarch64-apple-ios and x86_64-apple-darwin checks now run in
one job, with one cargo invocation per feature set that passes both
targets, so they also share the host-side build scripts and proc macros.
The matrix entry lists the targets separated by a space, because the
target is part of the cache key and actions/cache rejects commas.

This renames the two "cargo check (macos-latest, ...)" checks to one.

Assisted-by: Claude Code
Claude-Session: https://claude.ai/code/session_01JpHqXiC3mDShqfsPxvr9ey
@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@moreal moreal changed the title Ci/snippets cpython ubuntu only Cut redundant CI work Oct 25, 2026
@moreal moreal self-assigned this Oct 25, 2026

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@youknowone
youknowone marked this pull request as ready for review October 26, 2026 01:45
@youknowone
youknowone merged commit 76b3b00 into RustPython:main Oct 26, 2026
27 of 28 checks passed
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-26T01:45:13.912879Z 86d9ce1 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@fanninpm
fanninpm requested a review from ShaharNaveh October 26, 2026 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants