Repository navigation
Add canonical sampling profiler CLI for offline replay - #9358
Conversation
Import the CLI, entry point, error type, coordinator dependency, and CLI tests with scripts/update_lib migrate from CPython 3.15.0 at d220409a13b77de7a6c30abe16ea90db01528edc. This frontend follows the existing offline collector/codec support. Live attach, run, and dump remain unsupported and unvalidated. Assisted-by: OpenAI Codex: model version unavailable
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 5
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
📦 Library DependenciesThe following Lib/ modules were modified. Here are their dependencies: [ ] lib: cpython/Lib/profiling dependencies:
dependent tests: (3 tests)
Legend:
|
Merging this PR will not alter performance
Comparing Footnotes
|
Summary
d220409a13b77de7a6c30abe16ea90db01528edc) usingscripts/update_lib migrate: the CLI, entry point, error type, coordinator dependency, and upstream CLI tests.attach,run, anddumpremain unsupported and unvalidated, although canonical help advertises them. This PR does not add native unwinding or compressed-profile support.Validation
TestSampleProfilerCLItests passed, covering argument/help handling, replay validation and recorded-mode propagation, JSONL/binary collector metadata, and export-error handling. No test assertions, skips, or expected-failure markers were changed.AI assistance: OpenAI Codex (model version unavailable).