Skip to content

Add canonical sampling profiler CLI for offline replay - #9358

Merged
youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:split/python315-profiler-offline-cli
Oct 25, 2026
Merged

youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:split/python315-profiler-offline-cli

Conversation

@youknowdot

Copy link
Copy Markdown
Contributor

Summary

  • Split the canonical sampling-profiler CLI frontend from Integrate remaining Python 3.15 final runtime and libraries #8954, following the offline profiler support in Align profiler bindings and capability checks with Python 3.15 #9340.
  • Import five files unchanged from CPython 3.15.0 (d220409a13b77de7a6c30abe16ea90db01528edc) using scripts/update_lib migrate: the CLI, entry point, error type, coordinator dependency, and upstream CLI tests.
  • Enable the offline replay/conversion frontend for uncompressed supported-format profiles. Live attach, run, and dump remain unsupported and unvalidated, although canonical help advertises them. This PR does not add native unwinding or compressed-profile support.

Validation

  • Fresh release build on current main with the required standard-library and threading features passed.
  • Eleven selected existing TestSampleProfilerCLI tests passed, covering argument/help handling, replay validation and recorded-mode propagation, JSONL/binary collector metadata, and export-error handling. No test assertions, skips, or expected-failure markers were changed.
  • All five files match the pinned upstream bytes; a second official migration left them unchanged. Normal commit hooks passed.
  • This is focused local coverage, not all 55 methods or the full workspace/C-API suites. No live profiling commands were exercised.

AI assistance: OpenAI Codex (model version unavailable).

Import the CLI, entry point, error type, coordinator dependency, and CLI
tests with scripts/update_lib migrate from CPython 3.15.0 at
d220409a13b77de7a6c30abe16ea90db01528edc.

This frontend follows the existing offline collector/codec support. Live
attach, run, and dump remain unsupported and unvalidated.

Assisted-by: OpenAI Codex: model version unavailable
@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 5
  • Lib/profiling/sampling/__main__.py is excluded by !Lib/**
  • Lib/profiling/sampling/_sync_coordinator.py is excluded by !Lib/**
  • Lib/profiling/sampling/cli.py is excluded by !Lib/**
  • Lib/profiling/sampling/errors.py is excluded by !Lib/**
  • Lib/test/test_profiling/test_sampling_profiler/test_cli.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@youknowone
youknowone marked this pull request as ready for review October 25, 2026 07:42
@youknowone
youknowone enabled auto-merge (squash) October 25, 2026 07:42
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-25T07:43:39.135015Z
We couldn’t complete this review. Comment @codex review to try again.
e1a5429 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[ ] lib: cpython/Lib/profiling
[ ] test: cpython/Lib/test/test_profiling

dependencies:

  • profiling (native: main, _child_monitor, _css_utils, _format_utils, _lsprof, _remote_debugging, binary_collector, binary_reader, cli, collector, constants, display, dump, errors, gecko_collector, heatmap_collector, importlib.machinery, importlib.resources, importlib.util, itertools, jsonl_collector, live_collector, marshal, math, module_utils, opcode_utils, profiling.tracing, profiling.tracing._utils, pstats_collector, sample, stack_collector, string_table, sys, time, trend_tracker, widgets)
    • curses (native: _curses, _curses_panel, curses.ascii, has_key, sys)
    • io (native: _io, _thread, errno, msvcrt, sys)
    • opcode (native: _opcode, builtins)
    • platform (native: _wmi, itertools, sys, vms_lib, winreg)
    • site (native: _io, _pyrepl.main, _pyrepl.pager, _pyrepl.readline, _pyrepl.unix_console, _pyrepl.windows_console, atexit, builtins, errno, readline, sitecustomize, sys, usercustomize)
    • sysconfig (native: _sysconfig, _winapi, importlib.machinery, importlib.util, os.path, sys)
    • _colorize, abc, argparse, base64, collections, contextlib, dataclasses, functools, html, json, linecache, locale, optparse, os, pathlib, pstats, re, runpy, selectors, socket, statistics, subprocess, tempfile, threading, traceback, types, typing, uuid, webbrowser

dependent tests: (3 tests)

  • profiling: test_profiling
    • cProfile: test_cprofile test_pstats

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated

@codspeed

codspeed Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 4 skipped benchmarks1


Comparing youknowdot:split/python315-profiler-offline-cli (e1a5429) with main (9bd84b2)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@youknowone
youknowone merged commit 901eb88 into RustPython:main Oct 25, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants