Repository navigation
Handle full-width operands in the None-return scanner - #9347
Merged
youknowone merged 1 commit intoOct 25, 2026
Merged
Conversation
Use decoded logical instructions rather than the preceding raw operand byte. Check referenced constants by None identity and decode common constants without panicking. Assisted-by: OpenAI Codex:model unavailable
Contributor
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
youknowone
approved these changes
Oct 25, 2026
youknowone
marked this pull request as ready for review
October 25, 2026 06:12
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
youknowdot
added a commit
to youknowdot/RustPython
that referenced
this pull request
Oct 25, 2026
Integrate main at 9bd84b2 while preserving the published mega history. Keep the authentic profiler locator and capabilities from RustPython#9340, set-cycle GC from RustPython#9343, backward-compatible bytecode tooling from RustPython#9344, package paths from RustPython#9345, canonical Levenshtein coverage from RustPython#9346, and the safe full-width None-return scanner from RustPython#9347. Regenerate support helpers through the official updater from unchanged CPython d220409a13b7, preserving four exact existing-main neighborhoods. Retain the newer main specialization/C-stack helpers, Cargo environment adaptation, prior isolation checks and remaining Python 3.15 updates. The obsolete manual capability guard is superseded by the genuine API. Preserve unlanded explicit sharing modes and opcode override support. Ruff and XML vendor sources remain unchanged. Validation: normal hooks, locked host_env/VM/stdlib library check and strict Clippy, and the default CLI build. No target-runtime or full-suite pass is claimed for this composition. Assisted-by: OpenAI Codex:model version unavailable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract the None-return scanner fix from #8954, without capsule hooks or interpreter lifecycle changes.
The scanner now uses decoded logical instructions and full-width constant indices. Static example: EXTENDED_ARG 1; LOAD_CONST 0 addresses constant256, not constant0. If constant0 is None and constant256 is True, the old scanner incorrectly accepts the return; reversing those constants causes a false rejection.
The split also corrects two issues found during review of the original mega implementation: common-constant decoding is fallible, and loaded constants are checked by None identity rather than converting arbitrary co_consts objects. This avoids new panic paths and unnecessary conversion allocations.
Validation:
The canonical test covers ordinary returns; it does not distinguish the extended-operand case. That correction is supported by source-level operand analysis, not an added runtime probe. CPython3.15 explicitly leaves EXTENDED_ARG handling out of its equivalent scanner, so this is RustPython full-width operand correctness rather than a CPython boundary-parity claim. No Python tests or assertions were changed. Full workspace/C-API suites and capsule lifecycle execution were not run.
AI assistance is disclosed in the commit trailer; the exact model identifier was unavailable.