Skip to content

Align Python 3.15 bytecode tooling - #9344

Merged
youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:split/python315-opcode-tooling
Oct 25, 2026
Merged

youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:split/python315-opcode-tooling

Conversation

@youknowdot

Copy link
Copy Markdown
Contributor

Summary

Extract the independent bytecode-tooling changes from #8954.

  • Decode Python 3.15 IMPORT_NAME name indices and lazy/eager flags in the disassembly fallback, while preserving pre-3.15 indexing.
  • Reject opcode IDs that disagree with CPython or place RustPython-only instructions in occupied slots.
  • Restrict deoptimization families to the current opcode enum and avoid self/duplicate entries.
  • Reuse one CPython source analysis during a generator invocation.

This changes three tooling files only. It does not change the parser, interpreter, canonical libraries, generated metadata, or test fixtures. Unused metadata-override extensions from the integration branch are not included.

Validation

Against CPython 3.15.0 d220409a13b77de7a6c30abe16ea90db01528edc:

  • Normal commit hooks pass.
  • Both existing metadata generators, with outputs redirected outside the checkout, reproduce the tracked Rust and Python metadata byte-for-byte. One source analysis served 354 cache hits.
  • All 245 canonical opcode IDs match; the only RustPython-only entry, BuildListFromArg = 219, occupies an upstream-free slot. Controlled metadata-only invalid-ID checks reject both a wrong canonical ID and an occupied custom slot.
  • Direct disassembly-fallback comparisons match CPython 3.15 for nine ordinary, one lazy, and one eager import from existing source files. All nine pre-3.15 imports also match CPython 3.13. Both versions pass the existing disassembly CLI smoke check. Input fixtures are compiled/disassembled, not executed.

The unmodified baseline generator exceeded a bounded 90-second check without producing output; it is not reported as a pass or used for a timing claim. Workspace/C-API runtime suites were not run for this tooling-only change. Hosted CI is pending.

AI assistance: OpenAI Codex extracted, reviewed, and validated these changes under maintainer direction. Model version unavailable.

Extract independent bytecode tooling from the Python 3.15 integration. Decode packed import-name arguments without changing older-interpreter fallback behavior, validate canonical opcode numbering, bound deoptimization families to the enum, and reuse parsed CPython analysis.

Validated generators reproduce tracked metadata exactly; normal, lazy and eager import fallback matches canonical disassembly. No interpreter, generated metadata or test changes.

Assisted-by: OpenAI Codex: model version unavailable
@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@youknowone
youknowone marked this pull request as ready for review October 25, 2026 06:11
@youknowone
youknowone merged commit 65ee7ba into RustPython:main Oct 25, 2026
21 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-25T06:12:23.459830Z
We couldn’t complete this review. Comment @codex review to try again.
65c7fc5 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

youknowdot added a commit to youknowdot/RustPython that referenced this pull request Oct 25, 2026
Integrate main at 9bd84b2 while preserving the published mega history.
Keep the authentic profiler locator and capabilities from RustPython#9340, set-cycle
GC from RustPython#9343, backward-compatible bytecode tooling from RustPython#9344, package
paths from RustPython#9345, canonical Levenshtein coverage from RustPython#9346, and the safe
full-width None-return scanner from RustPython#9347.

Regenerate support helpers through the official updater from unchanged
CPython d220409a13b7, preserving four exact existing-main neighborhoods.
Retain the newer main specialization/C-stack helpers, Cargo environment
adaptation, prior isolation checks and remaining Python 3.15 updates.
The obsolete manual capability guard is superseded by the genuine API.

Preserve unlanded explicit sharing modes and opcode override support.
Ruff and XML vendor sources remain unchanged.

Validation: normal hooks, locked host_env/VM/stdlib library check and
strict Clippy, and the default CLI build. No target-runtime or full-suite
pass is claimed for this composition.

Assisted-by: OpenAI Codex:model version unavailable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants