Repository navigation
Fix busy interpreter test readiness race - #9328
Merged
youknowone merged 1 commit intoOct 23, 2026
Merged
Conversation
Publish readiness only after the main interpreter has completed its first operation, and bound the detached subinterpreter readiness wait. Preserve the original progress assertions, main deadline, and safepoint. AI assistance covered diagnosis, source changes, review, and focused validation. Assisted-by: OpenAI Codex:model-version-unavailable
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 1
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
youknowone
approved these changes
Oct 23, 2026
youknowone
marked this pull request as ready for review
October 23, 2026 16:00
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a readiness race in
busy_main_interpreter_does_not_block_subinterpreter:Cause and relation to #9317
The main worker previously published readiness before its first loop-condition check. The sub worker could observe readiness, finish its multiplication, and publish completion before main entered the loop. Main then returned zero operations and failed the progress assertion despite successful subinterpreter progress.
This is a separate, inherited test bug rather than a PyTime fixture regression:
main_operations > 0as the only VM failure. The whole test suite completed in 2.38 seconds, excluding the main worker's 30-second timeout path for this failure.94f92e4ab84f3c164299cbaea7ac110881a10f5dand head29404850a370aad85467a782b65d7b44349a5f62have identicalinterpreter.rsblobe6c4c2852feb1263f081f0582185cf0460fa70ab. Complete PyTime conversion fixtures and repair existing helpers #9317 changes only_testinternalcapi.rsand its privatepytime.rshelper.The repository's test-logic restriction was explicitly excepted by the requester for this actual bug only; the general rule remains unchanged.
Validation
cargo test --offline --locked -p rustpython-vm --features threading --lib --no-runpassed with default VM features plus threading.--exact --test-threads=1: 1 passed, 0 failed, 0 ignored, 174 filtered out, in 0.18 seconds.The first cold no-run build reached its 30-minute build limit without a compiler diagnostic; the authorized warm-cache continuation completed successfully. This is not a runtime-test timeout.
Validation is Linux x86-64 only. Full workspace tests, C-API tests, Clippy, parallel-suite execution, and other platforms were not run locally for this narrow change. No stress-loop or baseline-pass claim is made; broader CI results remain pending.
AI assistance: OpenAI Codex; exact model identifier unavailable. Used for diagnosis, implementation, independent source review, and scoped validation.