Skip to content

Fix busy interpreter test readiness race - #9328

Merged
youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:fix-busy-interpreter-readiness
Oct 23, 2026
Merged

youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:fix-busy-interpreter-readiness

Conversation

@youknowdot

Copy link
Copy Markdown
Contributor

Summary

Fix a readiness race in busy_main_interpreter_does_not_block_subinterpreter:

  • Publish readiness once, after the main interpreter successfully completes and counts its first arithmetic operation.
  • Bound the subinterpreter's readiness wait to 30 seconds, outside its attached VM, so failure or timeout before main readiness cannot leave it spinning forever.
  • Preserve every original arithmetic/progress assertion, the main worker's 30-second deadline, its safepoint, and both yields. No skips, sleeps, or interpreter-runtime changes.

Cause and relation to #9317

The main worker previously published readiness before its first loop-condition check. The sub worker could observe readiness, finish its multiplication, and publish completion before main entered the loop. Main then returned zero operations and failed the progress assertion despite successful subinterpreter progress.

This is a separate, inherited test bug rather than a PyTime fixture regression:

The repository's test-logic restriction was explicitly excepted by the requester for this actual bug only; the general rule remains unchanged.

Validation

  • Independent source review passed.
  • Normal repository commit hooks passed.
  • cargo test --offline --locked -p rustpython-vm --features threading --lib --no-run passed with default VM features plus threading.
  • Exact test listing identified one test. That test ran once with --exact --test-threads=1: 1 passed, 0 failed, 0 ignored, 174 filtered out, in 0.18 seconds.
  • The focused run used an external 60-second process-group deadline and resource limits. Source and binary hashes were unchanged before/after; cleanup found no remaining descendants.

The first cold no-run build reached its 30-minute build limit without a compiler diagnostic; the authorized warm-cache continuation completed successfully. This is not a runtime-test timeout.

Validation is Linux x86-64 only. Full workspace tests, C-API tests, Clippy, parallel-suite execution, and other platforms were not run locally for this narrow change. No stress-loop or baseline-pass claim is made; broader CI results remain pending.

AI assistance: OpenAI Codex; exact model identifier unavailable. Used for diagnosis, implementation, independent source review, and scoped validation.

Publish readiness only after the main interpreter has completed its first operation, and bound the detached subinterpreter readiness wait. Preserve the original progress assertions, main deadline, and safepoint.

AI assistance covered diagnosis, source changes, review, and focused validation.

Assisted-by: OpenAI Codex:model-version-unavailable
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between 5dcef1a and 7604857.

📒 Files selected for processing: 1
  • crates/vm/src/vm/interpreter.rs
+--------------------------------------------------------+
| Maybe I am just like my mother. She's never satisfied. |
+--------------------------------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@youknowone
youknowone marked this pull request as ready for review October 23, 2026 16:00
@youknowone
youknowone merged commit 0dc77fa into RustPython:main Oct 23, 2026
21 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T16:02:55.660148Z 7604857 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants