Sync selected Python 3.15 core library tests and repr type errors by youknowdot · Pull Request #9321 · RustPython/RustPython

youknowdot · 2026-10-23T01:23:36Z

Summary

Synchronize ten selected library paths with CPython 3.15.0 at d220409a13b77de7a6c30abe16ea90db01528edc, using the canonical updater and preserving existing RustPython adapters and expected-failure markers.

The synchronized ExceptionGroup regression exposed an actual main-RustPython failure: a non-string __repr__ result still produced __repr__ returned non-string (type NoneType) instead of the new qualified diagnostic. Update the generic Rust repr slot wrapper to emit {receiver_type}.__repr__() must return a str, not {result_type}, using the existing fully qualified type-name helper. Valid string results, including subclasses, and exceptions raised by __repr__ retain their existing paths.

The initial published head f128630 exposed another canonical regression in all three OS CI jobs: test_mutating_decode_handler_unicode_escape returned consumed length 4 after an error handler replaced an original six-byte buffer. The follow-up Rust fix retains the original input length on successful Unicode/raw-Unicode escape decoding and uses the current cursor only at existing incomplete non-final exits. This matches CPython's wrapper initialization and incomplete handling without changing buffer mutation, restart validation, warnings or canonical tests.

The 13-file patch contains:

Lib/platform.py and its tests: canonical normalization, deprecation and Python 3.15 API-removal changes.
Codec callback unregister coverage, ExceptionGroup repr coverage, builtin-function attributes, JSON escape/version cases, and frozendict set/UserDict coverage.
The required generic repr diagnostic fix in crates/vm/src/types/slot.rs.
Consumed-length accounting fixes in the two common Rust escape decoders.

Upstream test assertions, cases and guards are preserved rather than rewritten to accommodate RustPython. The canonical deep-ExceptionGroup stack guards and removal of the deprecated Java platform test come from the pinned CPython source; no local skip, xfail or assertion weakening was introduced to make the selected tests pass.

Validation

Linux, pinned Rust toolchain 1.99.1, with the candidate built from main Rust code plus this patch, not the separate vectorcall candidate:

cargo build --locked --offline --bin rustpython: passed.
cargo clippy --locked --offline -p rustpython-common -p rustpython-vm --lib -- -D warnings: passed on the codec-fix source; earlier VM-only lint also passed on the repr source.
Check-only rustfmt: earlier repr slot and both changed common escape-decoder files passed.
Normal commit hooks, without bypass: the initial commit passed merge-conflict, ruff format, redundant-test-patches, rustfmt, cspell and ruff checks; Prettier had no applicable files. The Rust-only codec follow-up passed merge-conflict, rustfmt and cspell; Python/Prettier hooks had no applicable files. Neither commit hook run changed tested source.
Bounded existing-TestCase selection: 55 passes and one canonical CPython-only skip, across ten fresh processes on the codec-fix source. Exact method selection preserved normal imports, fixtures and decorators; it did not use discovery or module-level load_tests.
- Platform: 1 pass, test__comparable_version canonically skipped.
- Codec callbacks: 4 passes, including the exact mutation method that failed CI, with all twelve canonical cases and three sliced-memoryview inputs.
- Unicode/raw-Unicode escape codecs: 11 passes, including ordinary, warning/error, incremental, StreamReader and partial-input regressions.
- ExceptionGroup repr: 6 passes, including test_repr_raises and its raised-exception propagation branch.
- UserDict: 2 passes.
- Sets/frozendict: 18 passes.
- JSON: 7 passes, with pure-Python and accelerated bad-escape/truncated-input cases and implementation identities checked separately.
- Builtin function attributes: 1 pass.
- Builtin repr/ascii: 3 passes.
- Descriptor/str-subclass repr: 2 passes.

Before the Rust fix, the same synchronized Lib files produced 5 passes, one canonical skip and the real test_repr_raises assertion failure; the original remaining 28 selectors were not run after that failure. Those results were retained. After rebuilding with the repr fix, all original 35 selectors and nine additional existing repr regressions ran under a new source/binary binding (43 passes and one canonical skip). The subsequent published f128630 CI failure in the Unicode mutation method was retained, not hidden by this bounded result. After the codec fix, all those 44 selectors plus twelve existing codec selectors ran under a separate fresh binding (55 passes and one canonical skip). The earlier initial build was interrupted without a terminal receipt; the successful retry and later fixed-source build reused verified owned compilation cache, not an unrelated binary.

Runtime source/tool/binary bindings, module-origin checks, per-ID accounting and resource checks passed in every completed fixed-source gate. The follow-up commit 03e7da1 has all 3,715 tracked file/link contents and modes independently verified against the final tested source manifest. Validation receipts retain their original pre-commit HEAD/status bindings; this is committed-source equivalence, not a claimed post-commit rerun.

Not run: complete affected-module suites, full workspace tests, separate crates/capi tests, release-profile validation, all-feature/build matrices, local Windows/macOS/WASM or other non-Linux checks. Earlier CI on f128630 failed the codec mutation case on Linux, macOS and Windows; a fresh CI result for the follow-up commit is not yet verified and is not implied by these Linux checks. These bounded results do not establish full Python 3.15 compatibility or whole-repository validation.

Relationship to other work

Fresh main was still e5554e23abfbaee85508c32fc22e5074f88aebdd when checked on October 23.

Among these ten Lib paths, only Lib/test/test_platform.py overlaps #8954. This is not ten extractions from that PR. The generic repr fix is new; #8954, #9320 and other open slot-related work touch different slot.rs areas. #6215 touches separate test_set.py hunks. This is a source-overlap review, not a merge-conflict simulation; related work may need reconciliation when landing.

AI assistance

OpenAI Codex assisted source synchronization/review, the Rust diagnostic and codec-accounting fixes, validation, and this PR description. The model version identifier is unavailable. These are automated checks, not a claim of human testing. The commit includes Assisted-by: OpenAI Codex:model version unavailable.

Synchronize ten selected library paths from CPython 3.15.0 at d220409a13b77de7a6c30abe16ea90db01528edc using the canonical updater, retaining existing RustPython adapters and failure markers. Match generic __repr__ invalid-result errors to the qualified type-name format required by the canonical ExceptionGroup regression, preserving string results and exceptions raised by the implementation. Implementation, source review, and validation were AI-assisted. The model version identifier is unavailable; automated checks are not human verification. Bounded validation covers 43 passes and one canonical skip, not the full repository suites. Assisted-by: OpenAI Codex:model version unavailable

coderabbitai · 2026-10-23T01:23:43Z

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Source mode: Auto
Repository: RustPython/RustPython
Branch: main
File: .coderabbit.yml
Commit: e5554e2
Layers: Repository YAML
Review profile: CHILL
Plan: Advanced
Run ID: 3f7e2477-18d1-44c6-a048-102c8a74983b

📥 Commits

Reviewing files that changed from the base of the PR and between e5554e2 and 03e7da1.

⛔ Files ignored due to path filters: 10

Lib/platform.py is excluded by !Lib/**
Lib/test/test_codeccallbacks.py is excluded by !Lib/**
Lib/test/test_exception_group.py is excluded by !Lib/**
Lib/test/test_funcattrs.py is excluded by !Lib/**
Lib/test/test_json/__init__.py is excluded by !Lib/**
Lib/test/test_json/test_fail.py is excluded by !Lib/**
Lib/test/test_json/test_scanstring.py is excluded by !Lib/**
Lib/test/test_platform.py is excluded by !Lib/**
Lib/test/test_set.py is excluded by !Lib/**
Lib/test/test_userdict.py is excluded by !Lib/**

📒 Files selected for processing: 3

crates/common/src/encodings/raw_unicode_escape.rs
crates/common/src/encodings/unicode_escape.rs
crates/vm/src/types/slot.rs

+-------------------------------------------------------------+
| All programming is an exercise in caching. - Terje Mathisen |
+-------------------------------------------------------------+
  \
   \     /)/)
        ( '')
        /  |
      o(___)

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-10-23T01:24:44Z

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[ ] lib: cpython/Lib/platform.py
[x] test: cpython/Lib/test/test_platform.py

dependencies:

platform (native: _wmi, itertools, sys, vms_lib, winreg)
- _ios_support (native: sys)
- ctypes (native: _ctypes, ctypes._aix, ctypes._endian, ctypes.macholib.dyld, ctypes.macholib.dylib, ctypes.macholib.framework, importlib.machinery, itertools, nt, sys)
- argparse, collections, functools, os, plistlib, re, socket, struct, subprocess, warnings

dependent tests: (33 tests)

platform: test__locale test__osx_support test_asyncio test_baseexception test_builtin test_calendar test_cmath test_ctypes test_fcntl test_math test_mimetypes test_os test_platform test_regrtest test_shutil test_socket test_ssl test_strptime test_sysconfig test_time test_tkinter test_winreg test_wsgiref
- idlelib: test_idle
- profiling.sampling.gecko_collector: test_profiling
- profiling.sampling.heatmap_collector: test_profiling
- pydoc: test_enum test_pydoc
  - pdb: test_pdb
  - xmlrpc.server: test_docxmlrpc test_xmlrpc
- uuid: test_os
  - wave: test_wave

[ ] test: cpython/Lib/test/test_set.py (TODO: 2)

dependencies:

dependent tests: (no tests depend on set)

[x] test: cpython/Lib/test/test_funcattrs.py (TODO: 1)

dependencies:

dependent tests: (no tests depend on funcattrs)

[x] test: cpython/Lib/test/test_dict.py (TODO: 1)
[ ] test: cpython/Lib/test/test_dictcomps.py
[x] test: cpython/Lib/test/test_dictviews.py (TODO: 1)
[x] test: cpython/Lib/test/test_userdict.py
[x] test: cpython/Lib/test/mapping_tests.py

dependencies:

dependent tests: (no tests depend on dict)

[x] lib: cpython/Lib/codecs.py
[x] test: cpython/Lib/test/test_charmapcodec.py
[x] test: cpython/Lib/test/test_codeccallbacks.py (TODO: 3)
[x] test: cpython/Lib/test/test_codecencodings_cn.py
[x] test: cpython/Lib/test/test_codecencodings_hk.py
[x] test: cpython/Lib/test/test_codecencodings_iso2022.py
[x] test: cpython/Lib/test/test_codecencodings_jp.py
[x] test: cpython/Lib/test/test_codecencodings_kr.py
[x] test: cpython/Lib/test/test_codecencodings_tw.py
[x] test: cpython/Lib/test/test_codecmaps_cn.py
[x] test: cpython/Lib/test/test_codecmaps_hk.py
[x] test: cpython/Lib/test/test_codecmaps_jp.py
[x] test: cpython/Lib/test/test_codecmaps_kr.py
[x] test: cpython/Lib/test/test_codecmaps_tw.py
[x] test: cpython/Lib/test/test_codecs.py (TODO: 2)
[x] test: cpython/Lib/test/test_multibytecodec.py
[x] test: cpython/Lib/test/testcodec.py

dependencies:

codecs

dependent tests: (186 tests)

[x] lib: cpython/Lib/json
[ ] test: cpython/Lib/test/test_json (TODO: 2)

dependencies:

json

dependent tests: (19 tests)

json: test_embed test_json test_logging test_plistlib test_profiling test_pydoc test_pyrepl test_subprocess test_sysconfig test_tomllib test_tools test_traceback test_zoneinfo
- importlib.metadata: test_importlib
- multiprocessing.resource_tracker: test_concurrent_futures
- pdb: test_pdb
- profiling: test_profiling
  - cProfile: test_cprofile test_pstats

[ ] test: cpython/Lib/test/test_exceptions.py (TODO: 2)
[ ] test: cpython/Lib/test/test_baseexception.py
[x] test: cpython/Lib/test/test_except_star.py
[x] test: cpython/Lib/test/test_exception_group.py
[x] test: cpython/Lib/test/test_exception_hierarchy.py
[x] test: cpython/Lib/test/test_exception_variations.py

dependencies:

dependent tests: (no tests depend on exception)

Legend:

[+] path exists in CPython
[x] up-to-date, [ ] outdated

Keep the original input length as consumed after successful unicode-escape and raw-unicode-escape decoding, including error-handler input replacement. Only report the current cursor when a non-final decode stops on incomplete input, matching CPython's codec wrappers and incomplete exits. Fix the canonical Unicode escape mutation regression that failed CI on Linux, macOS and Windows. Preserve all Lib tests and existing assertions. Bounded Linux validation: 55 passes and one canonical skip, CLI build and strict common/VM Clippy passed. Full repository suites were not run. Implementation, source review, and validation were AI-assisted. The model version identifier is unavailable; automated checks are not human verification. Assisted-by: OpenAI Codex:model version unavailable

chatgpt-codex-connector · 2026-10-23T09:01:23Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-23T09:08:39.227278Z	`03e7da1`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 03e7da1dae

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-10-23T09:08:36Z

                         '_json')


+class TestModule(unittest.TestCase):


Include the JSON version check in load_tests

When test_json is run through the normal module loader, this package's load_tests discards the loader-provided suite in _ and builds a fresh suite containing only doctests, TestPyTest, TestCTest, and discovered child modules. Since package discovery suppresses rediscovery of the package while its load_tests is active, TestModule.test_deprecated__version__ is never executed by the normal -m test test_json run; add this class to suite or retain the supplied tests so the new regression check actually runs.

Useful? React with 👍 / 👎.

youknowone approved these changes Oct 23, 2026

View reviewed changes

youknowone marked this pull request as ready for review October 23, 2026 09:01

youknowone merged commit c70e9b8 into RustPython:main Oct 23, 2026
20 of 21 checks passed

chatgpt-codex-connector Bot reviewed Oct 23, 2026

View reviewed changes

Navigation Menu

Repository navigation

Sync selected Python 3.15 core library tests and repr type errors - #9321

Sync selected Python 3.15 core library tests and repr type errors#9321
youknowone merged 2 commits into
RustPython:mainfrom
youknowdot:upgrade/python315-core-sync-repr

youknowdot commented Oct 23, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Oct 23, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

youknowdot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Relationship to other work

AI assistance

Uh oh!

coderabbitai Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Library Dependencies

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

youknowdot commented Oct 23, 2026 •

edited

Loading

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading

github-actions Bot commented Oct 23, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 23, 2026 •

edited

Loading