Repository navigation
Fix interpolated string warning diagnostic locations - #9314
Merged
youknowone merged 4 commits intoOct 24, 2026
Merged
youknowone merged 4 commits into
youknowone merged 4 commits into
Conversation
Contributor
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
youknowdot
force-pushed
the
fix-interpolated-warning-locations-20261022
branch
from
October 23, 2026 12:30
657e8a1 to
6f606cd
Compare
youknowone
approved these changes
Oct 23, 2026
Track CPython string-parser fragment anchors separately from escape source offsets. Preserve scoped error-line text and mode-specific final newlines with lazy sparse location indexing. Assisted-by: OpenAI Codex:model-version-unavailable
Assisted-by: OpenAI Codex (model version unavailable)
Reconstruct body and format-spec decoder fragments, preserve tokenizer/parser action order and pending Single/type-comment errors, and match Unicode protection plus scoped numeric and ordinary-token diagnostics. Assisted-by: OpenAI Codex:model-version-unavailable
Keep warning and error coordinates consistent across bare CR, CRLF, and LF while retaining file-input synthetic newlines. Assisted-by: OpenAI Codex:model-version-unavailable
youknowdot
force-pushed
the
fix-interpolated-warning-locations-20261022
branch
from
October 24, 2026 00:49
f1ef908 to
d02a4f1
Compare
youknowone
approved these changes
Oct 24, 2026
youknowone
marked this pull request as ready for review
October 24, 2026 02:28
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebased #9314 onto main
fd3c3fca644b93d0bec719efb3f864056b5d3b68and reviewed its implementation against CPython 3.15.0 sourced220409a13b77de7a6c30abe16ea90db01528edc.No canonical tests or Python library files were modified, no new RustPython behavior tests were added, and no diagnostic filtering or expected-output special cases were introduced.
Validation
The exact production source passed:
cargo check --offline --locked -p rustpython-vm --lib.cargo clippy --offline --locked -p rustpython-vm --lib -- -D warnings.cargo build --offline --locked --bin rustpython.An independent readonly candidate binary was sealed and its actual native and Python-module origins verified. Every gate checked source/tool/Lib bindings. Candidate source patch SHA256:
2a3f8ba850233eee80a0a2df4972363697d1707ae57e42a40d3cd4a1f958a7df (final follow-up delta against validated v8); binary SHA256:eb75c0a58986a48142d3ae7986823b89c520c6c8224da8ba925841cbb565b9a5.All 832 observations agree on warning lists and exception selection/chaining, including f/t body, format-spec, brace-tokenizer locations and the added numeric/ordinary-text corrections. The final follow-up corrected exactly four ordinary exec bare-CR rows; the other 828 rows were unchanged.
Exact results and remaining boundaries
Full raw equality is 382/832. A further 382 rows differ only in existing global SyntaxError args/repr construction. The remaining 68 rows retain other diagnostic differences: rejected TYPE_COMMENT validator ranges (40), Single generic-error LF text (18), the explicit malformed-source fallback control (10). These are recorded, not normalized away. General ordinary-string diagnostics outside the reviewed final-line scope are not claimed globally equivalent.
Arbitrary custom warning-callback exception conversion, complete malformed-source parser recovery, global SyntaxError argument tuples, and real-file filename lookup are not rewritten or claimed fully equivalent. Full workspace/CAPI suites and entire Python test modules were not run in this bounded validation.
AI assistance: OpenAI Codex (model version unavailable); commits contain Assisted-by trailers.