Repository navigation
build(deps): bump the wasmtime group across 1 directory with 2 updates - #9309
dependabot[bot] wants to merge 1 commit into
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
6ac9108 to
7dc278b
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7dc278b752
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| cranelift = "0.136.3" | ||
| cranelift-jit = "0.135.0" | ||
| cranelift-module = "0.135.0" | ||
| cranelift-module = "0.136.3" |
There was a problem hiding this comment.
Keep all Cranelift JIT crates on the same release
When building with --features jit, crates/jit combines types and traits from cranelift, cranelift-jit, and cranelift-module, but this change upgrades the first and third to 0.136 while leaving cranelift-jit on 0.135. The lockfile consequently contains both 0.135 and 0.136 copies of core Cranelift crates, so JITModule implements the 0.135 Module trait and uses 0.135 IR types while this crate imports their incompatible 0.136 counterparts; supported JIT builds therefore no longer compile. Upgrade/migrate cranelift-jit with the other crates, or retain the 0.135 versions until that is possible.
AGENTS.md reference: AGENTS.md:L259-L263
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@coderabbitai how can I manipulate .github/dependabot.yml so that this happens?
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
ast-grep outline .github/dependabot.yml
sed -n '1,260p' .github/dependabot.ymlLength of output: 4020
🤖 web_search executed:
GitHub Dependabot groups configuration patterns first matching group update-types minor patch cargo groups do not guarantee same dependency versions
Length of output: 14491
@fanninpm Your configuration already groups these dependencies in .github/dependabot.yml:
wasmtime:
patterns:
- "cranelift*"
- "wasmtime*"The "cranelift*" pattern matches all three crates. Grouping puts available updates in one PR. It does not require all matching crates to reach the same release. Adding a separate cranelift group would not enforce that requirement.
To prevent partial automatic updates
If you want to update Cranelift manually as a coordinated set, add this entry to the Cargo section’s existing ignore list. Keep the existing ruff_* entry:
ignore:
# Update Cranelift manually as a coordinated set.
- dependency-name: "cranelift*"
# Keep the existing Ruff exclusion.
- dependency-name: "ruff_*"This disables routine Dependabot version updates for matching crates. It does not automate coordinated upgrades. GitHub documents ignore as the control for excluding dependencies from version updates. Dependabot documentation
To keep automatic updates
Keep the current group, but require a JIT build check before merging:
cargo check --locked --features jitRun that check in CI with the repository’s required Rust toolchain. Grouping alone cannot replace this compatibility check.
For this PR, the configuration change would not fix the existing version mismatch. Update and migrate all three crates to a compatible release set, or restore the previous compatible versions.
You are interacting with an AI system.
Merging this PR will not alter performance
Comparing Footnotes
|
7dc278b to
9f290ec
Compare
Bumps the wasmtime group with 2 updates in the / directory: [cranelift](https://github.com/bytecodealliance/wasmtime) and [cranelift-module](https://github.com/bytecodealliance/wasmtime). Updates `cranelift` from 0.135.2 to 0.136.3 - [Release notes](https://github.com/bytecodealliance/wasmtime/releases) - [Changelog](https://github.com/bytecodealliance/wasmtime/blob/main/RELEASES.md) - [Commits](https://github.com/bytecodealliance/wasmtime/commits) Updates `cranelift-module` from 0.135.3 to 0.136.3 - [Release notes](https://github.com/bytecodealliance/wasmtime/releases) - [Changelog](https://github.com/bytecodealliance/wasmtime/blob/main/RELEASES.md) - [Commits](https://github.com/bytecodealliance/wasmtime/commits) --- updated-dependencies: - dependency-name: cranelift dependency-version: 0.136.3 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: wasmtime - dependency-name: cranelift-module dependency-version: 0.136.3 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: wasmtime ... Signed-off-by: dependabot[bot] <[email protected]>
9f290ec to
cddcb08
Compare
|
This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests. To ignore these dependencies, configure ignore rules in dependabot.yml |
Bumps the wasmtime group with 2 updates in the / directory: cranelift and cranelift-module.
Updates
craneliftfrom 0.135.2 to 0.136.3Commits
Updates
cranelift-modulefrom 0.135.3 to 0.136.3Commits