Repository navigation
Fix numeric warning error start offsets - #9305
Merged
youknowone merged 1 commit intoOct 22, 2026
Merged
youknowone merged 1 commit into
youknowone merged 1 commit into
Conversation
Assisted-by: OpenAI: GPT-6.1
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 1
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
youknowone
approved these changes
Oct 22, 2026
youknowone
marked this pull request as ready for review
October 22, 2026 14:24
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #9296, based independently on tested main 0b0a360. Use the existing numeric literal's last-character position when a parser-collected numeric SyntaxWarning becomes SyntaxError in noninteractive compilation. Interactive compilation already uses that position.
For example, the offset for
compile('0b1and 2', ..., 'exec')with SyntaxWarning configured as an error changes from 1 to 3, matching CPython 3.15.0. The same applies to AST compilation and Unicode character columns.This changes only the collector's offset argument. It does not change warning order or callback arguments, exception conversion/stringification, original-filename handling, or interactive behavior. It is not the broader numeric metadata patch prepared on #9282: end positions, error text/newline policy, lone-CR normalization and SyntaxError args remain outside this PR. The separate #9282 work is not included or superseded.
Validation:
No Lib changes, expectedFailure removal or bespoke behavior tests. The canonical numeric warning method does not currently assert this offset; the finite observation matrix checks it directly without executing generated code. Full workspace/CAPI test suites were not run.
AI assistance was used for implementation and validation.