Repository navigation
Align percent formatting with Python 3.15 final - #9125
Conversation
Parse and convert percent fields in order, preserve callback precedence, and align argument-context errors and keyed conversion restrictions. Keep invalid character-length checks ahead of index conversion and cover bounded callback ordering. Assisted-by: OpenAI Codex:model version unavailable
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 3
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c3fff85ff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ) | ||
|
|
||
|
|
||
| def test_percent_callback_order_bounded(): |
There was a problem hiding this comment.
Remove the newly added snippet test
This function adds new test logic and assertions to a test file, but the root AGENTS.md states that the only acceptable test-file edits are adding an expectedFailure marker or removing one together with its TODO; this change is neither permitted case and should be removed from the patch.
AGENTS.md reference: AGENTS.md:L273-L280
Useful? React with 👍 / 👎.
Summary
Focused extraction from #8954 onto main 0f93210. Only two Rust files and an appended snippet function; no Lib edits, dependency changes, compiler/IR work, OS APIs or XML changes.
Validation
cargo clippy --locked -p rustpython-common -p rustpython-vm --all-targets -- -D warnings, normal repository hooks andgit diff --checkpassed.80a9afe1c3a2fb17db0183e18e6428d24c85b7dfd1c1cd6e4075a9cf9275745b.Source review: the exact diff and runners passed independent review. Canonical method/helper ASTs match CPython d220409a13b77de7a6c30abe16ea90db01528edc; the runner uses minimal harness classes and requires 64-bit sizes before allowing methods with unreachable 32-bit allocation branches. Existing #9052 snippet logic is unchanged.
Limits
No full workspace/C-API suites, complete Python formatting/string/bytes suites, 32-bit/Windows/WASM runtime, concurrency or huge-allocation probes. Fallible width reservation is not a general huge-precision safety claim. No performance or human manual validation is claimed.
AI assistance: OpenAI Codex prepared the extraction, source review and validation tooling. The exact model version is not exposed by this runtime. Publication follows the maintainer’s authorized split workflow.