Skip to content

CI: bound dependency comments and retain complete reports - #8958

Draft
youknowdot wants to merge 1 commit into
RustPython:mainfrom
youknowdot:fix-lib-deps-comment-size
Draft

CI: bound dependency comments and retain complete reports#8958
youknowdot wants to merge 1 commit into
RustPython:mainfrom
youknowdot:fix-lib-deps-comment-size

Conversation

@youknowdot

@youknowdot youknowdot commented Oct 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

#9299 has landed and already truncates the raw dependency report at 60,000 UTF-8 bytes. This revision resolves the overlap while retaining the remaining improvement: keep the complete report and pass comment content through a file rather than multiline GITHUB_OUTPUT and the comment action's environment input.

  • Keep composed comments below 60,000 UTF-8 bytes, including their heading and legend. Longer reports get a link to the workflow run.
  • Retain the full report in the job summary up to its 1 MiB limit. Larger reports use the lib-deps-report artifact, with a pointer in the summary.
  • Preserve the trigger, token permissions, checkout/trust boundary, pinned actions, and no-Lib-change comment removal.

The lossy raw-report truncation is replaced by this composed-comment limit, not duplicated. No Lib/ or Rust source is changed. The workflow uses the trusted base revision, so this takes effect for library PRs only after it lands on main.

Current revision

Based on main 94f92e4ab84f3c164299cbaea7ac110881a10f5d, with one workflow-only commit 21d6132cf1683d0ae2ba65f34ee9b74fc44cbead. The reconciled workflow is byte-identical to the earlier PR workflow blob 30b17bf98c7efcc51290bbb8d1cd26d635034263; all other current-main files are unchanged. Original author attribution and the assistance trailer are preserved.

Validation

  • 18 local fixtures passed against the exact inline helper and capture shell: empty/small reports, literal output delimiters, the recorded 157,859-byte report size, ASCII and multibyte composed-body boundaries at 59,999/60,000/60,001 bytes and 1 MiB ± 1 byte, and successful/tolerated-failure report commands.
  • Verified complete report preservation, summary/artifact selection, workflow-run links, and file-only comment transport.
  • YAML parsing, unchanged trigger/permissions/setup/action pins/removal checks, normal configured commit hooks, and whitespace checks passed. Non-applicable hooks skipped normally.

No new native build, interpreter runtime test, workflow dispatch, or live comment/artifact posting was performed. No fresh actionlint or zizmor result is claimed. The earlier revision's zizmor comparison reported the same inherited dangerous-triggers finding on its base and candidate; that was not a clean scan.

AI assistance: prepared and validated with Codex at the user's direction. Exact model metadata is unavailable; the commit records Assisted-by: Codex:model-version-unavailable.

@coderabbitai

coderabbitai Bot commented Oct 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@youknowdot youknowdot mentioned this pull request Oct 4, 2026
Draft
@youknowdot
youknowdot force-pushed the fix-lib-deps-comment-size branch 2 times, most recently from b067caa to 03dcc7c Compare October 11, 2026 03:21
@youknowone
youknowone changed the base branch from main to stack/python-3.15-8950 October 11, 2026 03:24
@youknowdot
youknowdot force-pushed the fix-lib-deps-comment-size branch from 03dcc7c to dec4547 Compare October 11, 2026 04:07
@youknowone
youknowone changed the base branch from stack/python-3.15-8950 to main October 11, 2026 04:07
@youknowdot
youknowdot force-pushed the fix-lib-deps-comment-size branch from dec4547 to 89d0779 Compare October 11, 2026 04:14
@youknowdot youknowdot mentioned this pull request Oct 11, 2026
Merged
@github-actions

github-actions Bot commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[ ] test: cpython/Lib/test/test_mmap.py (TODO: 19)

dependencies:

dependent tests: (2 tests)

  • mmap: test_os
    • multiprocessing.shared_memory: test_genericalias

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated

@youknowdot
youknowdot force-pushed the fix-lib-deps-comment-size branch from 89d0779 to 8ec23f5 Compare October 11, 2026 19:44
youknowdot added a commit to youknowdot/RustPython that referenced this pull request Oct 15, 2026
@youknowdot
Integrate remaining CPython 3.15 final runtime and library changes
440fb23 
Rebase the remaining integration onto current main while retaining merged compiler and runtime fixes. Import canonical CPython v3.15.0 library sources through update_lib with preserved RustPython markers and explicit migration deferrals.

Include the published dependency-report fix from PR RustPython#8958, partial slot correction from PR RustPython#9127, and update_lib repair with existing-workflow coverage from PR RustPython#9131.

Assisted-by: OpenAI Codex:model version unavailable
youknowdot added a commit to youknowdot/RustPython that referenced this pull request Oct 15, 2026
@youknowdot
Integrate remaining CPython 3.15 final runtime and library changes
d6587ca 
Rebase the remaining integration onto current main while retaining merged compiler and runtime fixes. Import canonical CPython v3.15.0 library sources through update_lib with preserved RustPython markers and explicit migration deferrals.

Include the published dependency-report fix from PR RustPython#8958, partial slot correction from PR RustPython#9127, and update_lib repair with existing-workflow coverage from PR RustPython#9131.

Assisted-by: OpenAI Codex:model version unavailable
youknowdot added a commit to youknowdot/RustPython that referenced this pull request Oct 18, 2026
@youknowdot
Integrate remaining CPython 3.15 final runtime and library changes
9cb81d6 
Rebase the remaining integration onto current main while retaining merged compiler and runtime fixes. Import canonical CPython v3.15.0 library sources through update_lib with preserved RustPython markers and explicit migration deferrals.

Include the published dependency-report fix from PR RustPython#8958, partial slot correction from PR RustPython#9127, and update_lib repair with existing-workflow coverage from PR RustPython#9131.

Assisted-by: OpenAI Codex:model version unavailable
youknowdot added a commit to youknowdot/RustPython that referenced this pull request Oct 18, 2026
@youknowdot
Integrate remaining CPython 3.15 final runtime and library changes
3416074 
Rebase the remaining integration onto current main while retaining merged compiler and runtime fixes. Import canonical CPython v3.15.0 library sources through update_lib with preserved RustPython markers and explicit migration deferrals.

Include the published dependency-report fix from PR RustPython#8958, partial slot correction from PR RustPython#9127, and update_lib repair with existing-workflow coverage from PR RustPython#9131.

Assisted-by: OpenAI Codex:model version unavailable
youknowdot added a commit to youknowdot/RustPython that referenced this pull request Oct 18, 2026
@youknowdot
Integrate remaining CPython 3.15 final runtime and library changes
732b3a2 
Rebase the remaining integration onto current main while retaining merged compiler and runtime fixes. Import canonical CPython v3.15.0 library sources through update_lib with preserved RustPython markers and explicit migration deferrals.

Include the published dependency-report fix from PR RustPython#8958, partial slot correction from PR RustPython#9127, and update_lib repair with existing-workflow coverage from PR RustPython#9131.

Assisted-by: OpenAI Codex:model version unavailable
@youknowdot
CI: bound dependency comments and retain complete reports
21d6132 
Pass dependency reports through files, retain short reports in comments, and preserve complete longer reports in summaries or artifacts. Keep existing triggers, permissions, action pins, and trust boundaries.

Assisted-by: Codex:model-version-unavailable
@youknowdot
youknowdot force-pushed the fix-lib-deps-comment-size branch from 8ec23f5 to 21d6132 Compare October 22, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

1 participant

@youknowdot