Skip to content

Skip C-API in workspace coverage - #8619

Merged
youknowone merged 1 commit into
RustPython:mainfrom
moreal:ci/exclude-capi-from-coverage
Sep 12, 2026
Merged

Skip C-API in workspace coverage#8619
youknowone merged 1 commit into
RustPython:mainfrom
moreal:ci/exclude-capi-from-coverage

Conversation

@moreal

@moreal moreal commented Aug 30, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary

The periodic coverage job runs tests from the workspace root, which causes the rustpython-capi test binary to be built without the crate-local PyO3 configuration from crates/capi/.cargo/config.toml. The binary consequently crashes with SIGSEGV as soon as its unit tests start. This failure appeared in the run associated with #8616, but the same failure has also affected scheduled runs on main since C-API tests were enabled.

This change excludes rustpython-capi from the root workspace coverage invocation, matching the existing regular CI workflow. The C-API suite remains covered by its dedicated CI invocation from crates/capi, where all 102 tests pass with the required configuration. I also verified the remaining workspace tests, clippy, formatting, pre-commit hooks, actionlint, and the workflow security scan locally.

Summary by CodeRabbit

  • Chores
    • Updated Rust test coverage reporting to exclude an additional internal package.
    • No user-facing functionality or behavior changes.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0cfe087d-b0ff-4bac-9ffe-f91624c36fcf

📥 Commits

Reviewing files that changed from the base of the PR and between fc0069f and f2df899.

📒 Files selected for processing (1)
  • .github/workflows/cron-ci.yaml

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

Walkthrough

The cron CI workflow excludes rustpython-capi from Rust coverage collection in the codecov job.

Changes

Coverage workflow

Layer / File(s) Summary
Exclude rustpython-capi from coverage
.github/workflows/cron-ci.yaml		 The cargo llvm-cov command excludes rustpython-capi along with the existing excluded packages.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to f2df8

The workflow stops collecting C-API coverage from the root workspace while retaining its dedicated coverage path; this is a localized CI behavior change with no actionable merge-blocking risk remaining after normal checks.

Suggested reviewers: shaharnaveh, youknowone

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely states the main change: excluding the C-API from workspace coverage.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the z-ca-2026 Tag to track Contribution Academy 2026 label Aug 30, 2026
@moreal moreal added the skip:ci Skip running the ci label Aug 30, 2026
@moreal moreal changed the title CI: exclude C-API tests from workspace coverage CI: skip C-API in workspace coverage Aug 30, 2026
@moreal moreal changed the title CI: skip C-API in workspace coverage Skip C-API in workspace coverage Aug 30, 2026
@moreal
moreal marked this pull request as ready for review August 30, 2026 07:33
@moreal
Exclude C-API tests from workspace coverage
f2df899 
Assisted-by: Codex:gpt-5.6-sol
@moreal
moreal force-pushed the ci/exclude-capi-from-coverage branch from 0a11833 to f2df899 Compare August 30, 2026 07:34
@moreal
moreal marked this pull request as draft August 30, 2026 07:35
@moreal
moreal marked this pull request as ready for review August 30, 2026 07:35
@moreal
moreal requested a review from youknowone August 30, 2026 08:08
bschoenmaeckers
bschoenmaeckers approved these changes Sep 1, 2026
View reviewed changes

@bschoenmaeckers bschoenmaeckers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@youknowone
youknowone merged commit 7d0a6a7 into RustPython:main Sep 12, 2026
31 of 33 checks passed
@youknowone

youknowone commented Sep 12, 2026

Copy link
Copy Markdown
Member

I am sorry to miss this, Thank you @moreal and @bschoenmaeckers !

youknowone pushed a commit that referenced this pull request Sep 16, 2026
@moreal
Exclude C-API tests from workspace coverage (#8619)
a582b93 
Assisted-by: Codex:gpt-5.6-sol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone Awaiting requested review from youknowone
1 more reviewer
@bschoenmaeckers bschoenmaeckers bschoenmaeckers approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@moreal moreal

Labels

skip:ci Skip running the ci z-ca-2026 Tag to track Contribution Academy 2026

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@moreal @youknowone @bschoenmaeckers