Skip to content

csv: validate dialect options #8402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 10 commits into from
Aug 21, 2026
Merged

csv: validate dialect options #8402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d49a37f
csv: validate dialect options
hyoinandout Jul 27, 2026
c698c86
cargo fmt
hyoinandout Aug 5, 2026
43ce785
Merge remote-tracking branch 'origin/main' into fix/csv-dialect-valid…
hyoinandout Aug 5, 2026
5e2da0c
csv: finalize merge resolution
hyoinandout Aug 5, 2026
70ebe18
Validate csv dialect conflicts with line terminators
hyoinandout Aug 7, 2026
3a145db
Remove stale CSV rejection snippet
hyoinandout Aug 9, 2026
0754731
Revert "Remove stale CSV rejection snippet"
hyoinandout Aug 9, 2026
b616808
Reapply "Remove stale CSV rejection snippet"
hyoinandout Aug 18, 2026
17519d8
Merge branch 'main' into fix/csv-dialect-validation
hyoinandout Aug 18, 2026
973bb3a
fix(csv): complete dialect merge resolution
hyoinandout Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Lib/test/test_csv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,10 @@ def _test_arg_valid(self, ctor, arg):
self.assertRaises(ValueError, ctor, arg,
quotechar='\x85', lineterminator='\x85')

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_reader_arg_valid(self):
self._test_arg_valid(csv.reader, [])
self.assertRaises(OSError, csv.reader, BadIterable())

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_writer_arg_valid(self):
self._test_arg_valid(csv.writer, StringIO())
class BadWriter:
Expand Down Expand Up @@ -1288,7 +1286,6 @@ class mydialect(csv.Dialect):
self.assertEqual(str(cm.exception),
'"lineterminator" must be a string, not NoneType')

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_invalid_chars(self):
def create_invalid(field_name, value, **kwargs):
class mydialect(csv.Dialect):
Expand Down
Loading