Skip to content

Move dependencies to workspace for capi crate#7795

Merged
youknowone merged 3 commits into
RustPython:mainfrom
fanninpm:move-deps-to-workspace-for-capi
May 9, 2026
Merged

Move dependencies to workspace for capi crate#7795
youknowone merged 3 commits into
RustPython:mainfrom
fanninpm:move-deps-to-workspace-for-capi

Conversation

@fanninpm
Copy link
Copy Markdown
Contributor

@fanninpm fanninpm commented May 7, 2026 •
edited by coderabbitai Bot
Loading

cc @ShaharNaveh @bschoenmaeckers

Summary by CodeRabbit

  • Chores
    • Standardized Python interoperability dependency management across the workspace, switching dev-dependencies to the shared configuration and enabling automatic initialization. No public APIs or runtime behavior changes for end users.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026 •
edited
Loading

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 50e53852-1afd-491c-895c-160e8fe41800

📥 Commits

Reviewing files that changed from the base of the PR and between 96158ac and 898cda2.

📒 Files selected for processing (1)
  • Cargo.toml
🚧 Files skipped from review as they are similar to previous changes (1)
  • Cargo.toml
📝 Walkthrough

Walkthrough

The PR adds pyo3 = "0.28" to workspace dependencies and updates crate dev-dependencies (notably crates/capi) to reference that workspace entry via workspace = true, preserving existing feature flags.

Changes

Workspace Dependency Centralization

Layer / File(s) Summary
Workspace Declaration
Cargo.toml		 pyo3 = "0.28" is added to [workspace.dependencies].
Crate Dev-Dependency Update
crates/capi/Cargo.toml, Cargo.toml		 Dev-dependency entries for pyo3 are changed from pinned versions to workspace = true, keeping features auto-initialize and abi3.
Metadata / Context
crates/capi/Cargo.toml		 package.metadata.cargo-shear remains with ignored = ["rustpython-stdlib"]; surrounding lines were re-anchored.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • ShaharNaveh

Poem

🐰 I hopped through manifests, neat and spry,
One pyo3 for all beneath the sky,
Crates now inherit with a gentle clue,
Workspace whispers softly: "I belong to you." ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: moving dependencies to workspace for the capi crate, which matches the actual modifications shown in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

bschoenmaeckers
bschoenmaeckers suggested changes May 7, 2026
View reviewed changes
Comment thread Cargo.toml Outdated
@ShaharNaveh @bschoenmaeckers
Update Cargo.toml
898cda2 
Co-authored-by: Bas Schoenmaeckers <[email protected]>
@youknowone youknowone merged commit bf7bb1b into RustPython:main May 9, 2026
25 checks passed
@fanninpm fanninpm deleted the move-deps-to-workspace-for-capi branch May 13, 2026 02:32
@coderabbitai coderabbitai Bot mentioned this pull request May 13, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShaharNaveh ShaharNaveh ShaharNaveh approved these changes

+1 more reviewer

@bschoenmaeckers bschoenmaeckers bschoenmaeckers requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fanninpm @bschoenmaeckers @ShaharNaveh @youknowone