Skip to content

Move dependencies to workspace for vm crate#7789

Merged
youknowone merged 2 commits into
RustPython:mainfrom
fanninpm:move-deps-to-workspace-for-vm
May 6, 2026
Merged

Move dependencies to workspace for vm crate#7789
youknowone merged 2 commits into
RustPython:mainfrom
fanninpm:move-deps-to-workspace-for-vm

Conversation

@fanninpm
Copy link
Copy Markdown
Contributor

@fanninpm fanninpm commented May 6, 2026 •
edited by coderabbitai Bot
Loading

cc @ShaharNaveh

Summary by CodeRabbit

  • Chores
    • Updated internal dependency management and build configuration.

Note: This release contains internal infrastructure updates with no visible user-facing changes or feature additions.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 6, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: ca39573e-8473-4b5b-8b71-efa5df0fc23c

📥 Commits

Reviewing files that changed from the base of the PR and between 22d4f43 and 44e04d8.

📒 Files selected for processing (2)
  • Cargo.toml
  • crates/vm/Cargo.toml
📝 Walkthrough

Walkthrough

This pull request expands and reorganizes Cargo.toml dependency declarations, adding multiple new crates (caseless, exitcode, errno, flamer, libloading, num_cpus, psm, half, uname, which, icu/x509/unicode tooling, etc.) and switching crates/vm/Cargo.toml to use workspace-managed dependency versions instead of explicit version literals.

Changes

Workspace Dependency Management

Layer / File(s) Summary
Workspace Dependency Definitions
Cargo.toml		 Root manifest expanded with new direct dependencies: caseless, exitcode, errno, flamer, half, libloading, num_cpus, psm, result-like, timsort, tk-sys, icu-related crates, x509-related crates, and others; entries reordered and grouped logically.
Workspace-Based References
crates/vm/Cargo.toml		 Multiple dependencies (caseless, flamer, half, psm, result-like, timsort) and platform-specific entries (exitcode, uname, rustyline, which, errno, widestring, libloading, num_cpus) switched from pinned versions to workspace = true declarations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • ShaharNaveh
  • youknowone

Poem

🐰 Dependencies dance, a rabbit does see,
Workspace delight, now unified and free!
From version strings long, to true so concise,
The manifest flows—oh, such order so nice!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: moving dependencies to workspace for the vm crate, which aligns with both the file-level summaries and commit messages.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@youknowone youknowone merged commit 1c43618 into RustPython:main May 6, 2026
25 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request May 6, 2026
Open
@fanninpm fanninpm deleted the move-deps-to-workspace-for-vm branch May 7, 2026 02:27
This was referenced May 7, 2026
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fanninpm @youknowone