Skip to content

Move dependencies to workspace for jit crate#7720

Merged
youknowone merged 2 commits into
RustPython:mainfrom
fanninpm:move-deps-to-workspace-for-jit
Apr 29, 2026
Merged

Move dependencies to workspace for jit crate#7720
youknowone merged 2 commits into
RustPython:mainfrom
fanninpm:move-deps-to-workspace-for-jit

Conversation

@fanninpm
Copy link
Copy Markdown
Contributor

@fanninpm fanninpm commented Apr 28, 2026 •
edited by coderabbitai Bot
Loading

cc @ShaharNaveh

Summary by CodeRabbit

  • Chores
    • Updated workspace dependency management to centralize version control for build tools and libraries, improving consistency across the project structure.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 28, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: cd948e18-8411-402c-b26e-483ba9b83a4c

📥 Commits

Reviewing files that changed from the base of the PR and between 3f718f9 and ef9c3f1.

📒 Files selected for processing (2)
  • Cargo.toml
  • crates/jit/Cargo.toml
📝 Walkthrough

Walkthrough

The PR consolidates Cranelift compiler toolchain crates (cranelift, cranelift-jit, cranelift-module at version 0.131.0) and the approx library (0.5.1) into workspace-level dependency management, then updates the jit crate to inherit versions from the workspace instead of maintaining locally pinned versions.

Changes

Cohort / File(s) Summary
Workspace Dependencies
Cargo.toml		 Added Cranelift toolchain crates (0.131.0) and approx library (0.5.1) to workspace.dependencies section for centralized version management.
JIT Crate Dependencies
crates/jit/Cargo.toml		 Migrated cranelift, cranelift-jit, cranelift-module, and approx dependencies to use workspace version inheritance instead of locally pinned versions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • RustPython#7710: Implements the same workspace dependency consolidation pattern, moving per-crate pinned versions to centralized workspace management.

Suggested reviewers

  • ShaharNaveh
  • youknowone

Poem

🐰 Four crates hop into the workspace fold,
No more scattered versions, loose and cold,
Cranelift and approx now unified,
In workspace.dependencies, side by side! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: moving the jit crate's dependencies to the workspace for centralized management.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

ShaharNaveh
ShaharNaveh approved these changes Apr 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ShaharNaveh ShaharNaveh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty for doing these:)

@youknowone youknowone merged commit 51e7200 into RustPython:main Apr 29, 2026
20 checks passed
@fanninpm fanninpm deleted the move-deps-to-workspace-for-jit branch April 30, 2026 00:29
This was referenced May 1, 2026
Merged
Merged
Open
@coderabbitai coderabbitai Bot mentioned this pull request May 15, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShaharNaveh ShaharNaveh ShaharNaveh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fanninpm @ShaharNaveh @youknowone