Add global type mutex for thread-safe type operations#7416
Draft
youknowone wants to merge 1 commit intoRustPython:mainfrom
Draft
Add global type mutex for thread-safe type operations#7416youknowone wants to merge 1 commit intoRustPython:mainfrom
youknowone wants to merge 1 commit intoRustPython:mainfrom
Conversation
Introduce vm.state.type_mutex to serialize type mutation and version-tag assignment, matching CPython's free-threading model. - Add with_type_lock() helper and split modified/assign_version_tag into inner (lock-free) and public (lock-acquiring) variants - Add version_for_specialization() and lookup_ref_and_version_interned() for atomic type-cache lookups under the lock - Wrap all type-mutating paths (__bases__, __annotations__, __module__, __type_params__, __doc__, SetAttr) with the type lock - Drop old values outside the lock to prevent deadlock from weakref callbacks that may re-enter specialization - Fix _ctypes set_attr calls to route through proper SetAttr path - Reinitialize type_mutex after fork
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce vm.state.type_mutex to serialize type mutation and version-tag assignment, matching CPython's free-threading model.