Skip to content

Enable jit on macos (CI)#7401

Merged
youknowone merged 1 commit intoRustPython:mainfrom
ShaharNaveh:macos-jit
Mar 12, 2026
Merged

Enable jit on macos (CI)#7401
youknowone merged 1 commit intoRustPython:mainfrom
ShaharNaveh:macos-jit

Conversation

@ShaharNaveh
Copy link
Contributor

@ShaharNaveh ShaharNaveh commented Mar 11, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Simplified CI/CD test execution to ensure consistent testing across all platforms.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 11, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 41f49bcd-df17-416c-9adb-a09da21dbf34

📥 Commits

Reviewing files that changed from the base of the PR and between d248a04 and 95357c1.

📒 Files selected for processing (1)
  • .github/workflows/ci.yaml
💤 Files with no reviewable changes (1)
  • .github/workflows/ci.yaml
📝 Walkthrough

Walkthrough

The pull request removes a macOS-specific conditional step in the CI workflow that previously excluded the rustpython-jit package from cargo tests. This consolidates the Rust test command to run identically across all operating systems, eliminating platform-specific branching logic.

Changes

Cohort / File(s) Summary
CI Workflow Consolidation
.github/workflows/ci.yaml		 Removes macOS-specific conditional that excluded rustpython-jit from cargo test, unifying the test command across all platforms.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • youknowone

Poem

🐰 One condition gone, the tests now aligned,
macOS joins the crew, no jit left behind,
Simpler workflows make the pipeline shine,
Cross-platform harmony, oh so divine! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Enable jit on macos (CI)' directly and clearly describes the main change: removing the macOS-specific exclusion of rustpython-jit from cargo tests, thereby enabling JIT compilation on macOS in the CI pipeline.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ShaharNaveh ShaharNaveh marked this pull request as ready for review March 11, 2026 13:34
@youknowone youknowone merged commit da745ba into RustPython:main Mar 12, 2026
13 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Mar 14, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShaharNaveh @youknowone