Revert "ast.NodeVisitor for import tracking (#7229)"#7230
Revert "ast.NodeVisitor for import tracking (#7229)"#7230youknowone merged 1 commit intoRustPython:mainfrom
ast.NodeVisitor for import tracking (#7229)"#7230Conversation
This reverts commit 804a7e4.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughNarrowed test→library name extraction to only strip the "test_" prefix and refactored import parsing from an AST-based ImportVisitor to regex-based functions (_extract_top_level_code, parse_test_imports, parse_lib_imports) in the update_lib scripts. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Haven't thought about the CI of this feature. I'll reopen it (and won't skip CI this time 😓 ) |
…stPython#7230) This reverts commit a47572c.
The feature was good, but skip ci missed test regression.
@ShaharNaveh lets fix the test and merge this again
Summary by CodeRabbit