Put RefCell around frames member of VirtualMachine.#706
Conversation
…irtualMachine to be immutable.
Note that (This comment actually applies to every other use of (This isn't to say we shouldn't merge this PR as it still moves in the right direction of allowing us to change from |
|
I'm aware that this makes it not fully cross thread safe, but it is a good step. We can change each occurence of RefCell into the proper thread safe thing to achieve this. Note that I would like to merge this first, before the second change which involves a lot of search and replace. |
|
I also replaced 'some' occurrences of |
|
Okay, how to proceed with this change? I see a lot of merge conflicts coming up. Maybe wait with this a little while and redo the changes? Advice and opinions welcome! |
|
Is there a reason to wait? I thought this was ready to merge (prior to the conflicts) |
|
I would merge the first commit now - it's approved and ready to go. Then do the big remove all the muts as separate PR - no need to review we all know it's coming and what it does. It's going to cause conflicts with in progress work whenever we do it. (I guess that's equivalent to just fixing the merge conflicts and merging this now.) |
|
Yeah, I'd recommend rolling back the |
2be9a31 to
8c0419e
Compare
This allows for VirtualMachine to be immutable. This is a first work into the direction that VirtualMachine is immutable.
This enables a few things: