Change the WASM example to use rustpython from npm#700
Merged
windelbouwman merged 1 commit intomasterfrom Mar 21, 2019
Merged
Conversation
| "//2": "library in a real app", | ||
| "dependencies": { | ||
| "rustpython_wasm": "file:../lib/pkg/" | ||
| "rustpython_wasm": "0.1.0-pre-alpha.1" |
Contributor
There was a problem hiding this comment.
Why would you do this? Then we cannot test the current version, but always go through a deployment phase via npm?
Member
Author
There was a problem hiding this comment.
This is for the example, not the demo. If someone just wanted to copy/paste the example and use it as their own project, currently, they couldn't do so, as it has a file: dependency; they'd have to change it to the version from npm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.