Repository navigation
CPython docs database for module items - #3098
Merged
Merged
Conversation
youknowone
force-pushed
the
doc-sync
branch
2 times, most recently
from
September 21, 2021 11:02
29e6cd7 to
b355715
Compare
3 of 4 tasks
DimitrisJim
reviewed
Sep 21, 2021
| from pydoc import ModuleScanner | ||
|
|
||
|
|
||
| def scan_modules(): |
Member
There was a problem hiding this comment.
Since this only concerns the builtins, why not use sys.builtin_module_names here?
Member
Author
There was a problem hiding this comment.
I tried it but found sys.bulitin_module_names is not covering all the c modules. I didn't investigate well but I think it is more like pre-loaded module before import.
Member
There was a problem hiding this comment.
huh, maybe that in combination with sys.stdlib_module_names then (but that landed in 3.10 I believe.
DimitrisJim
reviewed
Sep 21, 2021
youknowone
force-pushed
the
doc-sync
branch
from
September 21, 2021 19:29
b355715 to
0be63e6
Compare
youknowone
force-pushed
the
doc-sync
branch
from
September 22, 2021 01:32
0be63e6 to
064bfc5
Compare
DimitrisJim
approved these changes
Sep 22, 2021
DimitrisJim
left a comment
DimitrisJim
left a comment
Member
There was a problem hiding this comment.
lgtm. module and method docs aren't currently attached as they are for functions/classes but those could be a separate PR, you can choose if you want to merge this now or add them on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no more copy & paste