Repository navigation
Find key from only its attributes - #2932
Merged
youknowone merged 4 commits intoAug 23, 2021
Merged
youknowone merged 4 commits into
youknowone merged 4 commits into
Conversation
moreal
changed the title
moreal
force-pushed
the
bugfix/dict-contains-check-from-its-attributes
branch
from
August 22, 2021 07:33
fc47ff0 to
e544f65
Compare
At 'enum.py' 223 line, there is the code to check `member_type` contains some methods. But it was fixed to find attribute from base types, in RustPython#2932. So it seems appeared. ``` if not any(m in member_type.__dict__ for m in methods): ```
moreal
force-pushed
the
bugfix/dict-contains-check-from-its-attributes
branch
from
August 22, 2021 23:54
8b83124 to
91734d4
Compare
moreal
marked this pull request as draft
August 23, 2021 04:31
moreal
force-pushed
the
bugfix/dict-contains-check-from-its-attributes
branch
from
August 23, 2021 11:00
91734d4 to
3b744c9
Compare
moreal
marked this pull request as ready for review
August 23, 2021 11:46
youknowone
reviewed
Aug 23, 2021
moreal
force-pushed
the
bugfix/dict-contains-check-from-its-attributes
branch
from
August 23, 2021 13:01
3b744c9 to
0548fa1
Compare
youknowone
approved these changes
Aug 23, 2021
youknowone
approved these changes
Aug 23, 2021
eldpswp99
pushed a commit
to eldpswp99/RustPython
that referenced
this pull request
Sep 5, 2021
At 'enum.py' 223 line, there is the code to check `member_type` contains some methods. But it was fixed to find attribute from base types, in RustPython#2932. So it seems appeared. ``` if not any(m in member_type.__dict__ for m in methods): ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Currently, there is a bug to find a key from itself and the base types not only its attributes. If there was user defined class named
A,"__setattr__" in A.__dict__returnsTruebecauseobjecthas__setattr__thoughAclass doesn't.RustPython
CPython 3.8