Skip to content

Remove unnecessary slot wrapper addition #2879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 2 commits into from
Aug 14, 2021
Merged

Remove unnecessary slot wrapper addition #2879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecf7877
Remove unnecessary slot wrapper overwriting
moreal Aug 14, 2021
597771d
Unmark fixed tests
moreal Aug 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Lib/test/test_enum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1698,8 +1698,6 @@ class Test(Base):
test = 1
self.assertEqual(Test.test.test, 'dynamic')

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_no_duplicates(self):
class UniqueEnum(Enum):
def __init__(self, *args):
Expand Down
2 changes: 0 additions & 2 deletions vm/src/builtins/pytype.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,8 +467,6 @@ impl PyType {
let typ = new(metatype, name.as_str(), base, bases, attributes, slots)
.map_err(|e| vm.new_type_error(e))?;

vm.ctx.add_slot_wrappers(&typ);

// avoid deadlock
let attributes = typ
.attributes
Expand Down