Skip to content

Further tweaking whats_left: allow differing implementation #2764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 1 commit into from
Jul 29, 2021
Merged

Further tweaking whats_left: allow differing implementation #2764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions extra_tests/not_impl_gen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ def onerror(modname):
return list(modules.keys())


def dir_of_mod_or_error(module_name):
def dir_of_mod_or_error(module_name, keep_other=True):
# Importing modules causes ('Constant String', 2, None, 4) and
# "Hello world!" to be printed to stdout.
f = io.StringIO()
Expand All @@ -189,7 +189,7 @@ def dir_of_mod_or_error(module_name):
item = getattr(module, item_name)
item_mod = inspect.getmodule(item)
# don't repeat items imported from other modules
if item_mod is module or item_mod is None:
if keep_other or item_mod is module or item_mod is None:
result[item_name] = extra_info(item)
return result

Expand All @@ -201,7 +201,8 @@ def gen_modules():
for mod_name in scan_modules():
if mod_name in ("this", "antigravity") or mod_name in PEP_594_MODULES:
continue
dir_result = dir_of_mod_or_error(mod_name)
# when generating CPython list, ignore items defined by other modules
dir_result = dir_of_mod_or_error(mod_name, keep_other=False)
if isinstance(dir_result, Exception):
print(
f"!!! {mod_name} skipped because {type(dir_result).__name__}: {str(dir_result)}",
Expand Down