Repository navigation
Use inspect.getmodule to prevent redundant output in whats_left.sh - #2760
Merged
Merged
Conversation
youknowone
approved these changes
Jul 29, 2021
youknowone
left a comment
youknowone
left a comment
Member
There was a problem hiding this comment.
Thanks! now it will look even better.
Member
|
Do you have any suggestion about the signature check? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I (very slowly) progress toward making an actual contribution, I wanted to propose a tweak to
whats_left.sh. In its current form, the script usesdirto crawl the modules and this means that there is some redundant output from items defined somewhere else. A big culprit is__loader__(see #2732) but there are others. In total this shaves 388 (redundant) lines from the output. Themissing_itemsandmismatched_itemsgo down but I think that was because they overcounted before.Another thing I noticed in the output is that for some entries, RustPython is actually better than the CPython implementation. Many of the entries in
operatorhave a signature, where the CPython version returnsNone. I'm not sure it makes sense to include those in the output but that's a separate change.