wasm/notebook: mobile and tablet responsive layout#2363
Merged
coolreader18 merged 2 commits intoRustPython:masterfrom Dec 9, 2020
Merged
wasm/notebook: mobile and tablet responsive layout#2363coolreader18 merged 2 commits intoRustPython:masterfrom
coolreader18 merged 2 commits intoRustPython:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds responsive layout to
wasm/notebookon phone and ipad/tablets.The notebook looked decent/good on phone and iPad (especially when the iPad is flipped horizontally). Since I think those devices would be mostly used for reading code, not writing it, imho the layout is good enough for now (It can be better on phones tho).
Here are some screenshots from tests on real devices. There is a problem with Chrome on Android (will open an issue).
iPad (safari)
Android (Firefox)
Android (Chrome)
needs fixing, will create an issue.