Add as_integer_ratio to PyInt#1759
Merged
coolreader18 merged 1 commit intoRustPython:masterfrom Feb 12, 2020
minhnhdo:master
Merged
Add as_integer_ratio to PyInt#1759coolreader18 merged 1 commit intoRustPython:masterfrom minhnhdo:master
coolreader18 merged 1 commit intoRustPython:masterfrom
minhnhdo:master
Conversation
Contributor
Author
|
It looks like the failed runs are due to |
Member
|
Thanks for your contributing. import sys
if sys.version_info >= (3, 8):
# run 3.8 test here |
Contributor
Author
|
I'll try upgrading the Python version in GitHub workflow first. |
Contributor
@youknowone have already tried upgrading to 3.8 in #1705. I think that commenting out the tests and adding a |
Contributor
Author
|
@palaviv, sure, I'll modify this PR. |
Member
|
Thank you for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for
as_integer_ratioto the VM's integer number type,PyInt.Current behavior on master
Behavior after this pull request