Fallback exit code to 0 in case of overflow#1745
Merged
youknowone merged 1 commit intoRustPython:masterfrom Feb 5, 2020
arnavb:fix-exit-code
Merged
Fallback exit code to 0 in case of overflow#1745youknowone merged 1 commit intoRustPython:masterfrom arnavb:fix-exit-code
youknowone merged 1 commit intoRustPython:masterfrom
arnavb:fix-exit-code
Conversation
coolreader18
approved these changes
Feb 4, 2020
Member
coolreader18
left a comment
coolreader18
left a comment
There was a problem hiding this comment.
Looks good, thanks for contributing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1742
This PR changes the exit code to 0 if it overflows by replacing an
unwrap()call withunwrap_or(0). Let me know what you think @coolreader18!