Conversation
| # yield | ||
| # finally: | ||
| # if have_gc: | ||
| # gc.enable() |
There was a problem hiding this comment.
You should probably still yield here, since it's a context manager. Unless @contextlib.contextmanager works with non-generators.
compiler/src/symboltable.rs
Outdated
| ast::StringGroup::FormattedValue { value, .. } => { | ||
| ast::StringGroup::FormattedValue { | ||
| value, | ||
| conversion: _, |
There was a problem hiding this comment.
I think this is what's causing the failure, in both this and the other PR. You can just add .. after the fields you actually use.
There was a problem hiding this comment.
I fixed that at #1625. You can ignore the changes there as I will rebase once it is in.
There was a problem hiding this comment.
Ah okay, I didn't realize that that was passing now; I merged it.
vm/src/stdlib/faulthandler.rs
Outdated
| eprintln!("Stack (most recent call first):"); | ||
|
|
||
| Ref::map(vm.frames.borrow(), |frames| { | ||
| &for frame in frames { |
There was a problem hiding this comment.
Why not just for frame in vm.frames.borrow() { ... } ?
vm/src/stdlib/time_module.rs
Outdated
| "struct_time" => struct_time_type, | ||
| "time" => ctx.new_rustfunc(time_time) | ||
| "time" => ctx.new_rustfunc(time_time), | ||
| "perf_counter" => ctx.new_rustfunc(time_time), |
|
This is sincerely great news! |
| @@ -0,0 +1,5 @@ | |||
| # We import importlib *ASAP* in order to test #15386 | |||
| import importlib | |||
|
|
|||
There was a problem hiding this comment.
Would it make sense to place the libregrtest folder outside the Lib folder? Or has this discussion already happened?
palaviv
force-pushed
the
run-unittests
branch
from
382d8b0 to
88c477f
Compare
3 participants
This change include many different changes that allows us to run the CPython test using
libregtest. After the change you can do:This change is based on the change in #1625.