Lib/test/test_copy.py from CPython v3.8.1#1633
Merged
youknowone merged 2 commits intoRustPython:masterfrom Jan 31, 2020
Merged
Conversation
Contributor
|
@youknowone I have a put the test_bool.py unittests from CPython in |
palaviv
approved these changes
Jan 31, 2020
Contributor
palaviv
left a comment
palaviv
left a comment
There was a problem hiding this comment.
Looks good. Again if you can mark tests with skip instead of comment out I think it is better.
Member
Author
|
commented out tests make crash instead of rust error |
youknowone
force-pushed
the
test-copy
branch
2 times, most recently
from
d982378 to
4ea8a61
Compare
Contributor
|
Are they failing when compiling or when you run the test? If that is when you run the test I would prefer adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.