Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1059 +/- ##
==========================================
+ Coverage 64.65% 64.66% +<.01%
==========================================
Files 101 102 +1
Lines 18305 18356 +51
Branches 4042 4054 +12
==========================================
+ Hits 11836 11870 +34
- Misses 3688 3697 +9
- Partials 2781 2789 +8
Continue to review full report at Codecov.
|
palaviv
approved these changes
Jun 29, 2019
| if let Some(name) = Name::of(my_char) { | ||
| Ok(vm.new_str(name.to_string())) | ||
| } else { | ||
| match default { |
Contributor
There was a problem hiding this comment.
You can use unwrap_or here to make it nicer.
Contributor
Author
There was a problem hiding this comment.
Okay, but I'll keep it this way, its probably clear enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.