Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: uniswap-python/uniswap-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: RoscoeTheDog/uniswap-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 2 files changed
  • 1 contributor

Commits on Dec 22, 2023

  1. Configuration menu
    Copy the full SHA
    8c04964 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2023

  1. added *args, **kwargs to constructor

    When creating a wrapper class for this API, I encountered issues passing down a flattened dict of kwargs to the constructor of Uniswap() class due to it not having *args, **kwargs in it's constructors signature. Any extra arguments that were not explicitily in the constructors signature would throw an error, which makes it less friendly for other software systems to wrap it's code with.
    
    Simply adding *args and **kwargs to the constructor fixes this issue and doesn't intrtoduce any negative effects.
    RoscoeTheDog committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    f8abbab View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. added "simulate" kwarg to make_trade

    Simulate can now be specified to return an estimate of the gas fees as well as some other useful metadata for the transaction. Does NOT take into account slippage or price impact for a transaction!!
    
    This was mostly needed so I could find the gas fees ahead of time before pushing an order on-chain and allows me to adjust the amount of network fee token buyback prior to it.
    RoscoeTheDog committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    a477a71 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. Update uniswap.py

    bug fixes when building and pushing transactions
    RoscoeTheDog committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    bc1b18d View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. fixed simulate checks wallet balances

    simulate no longer checks balances
    RoscoeTheDog committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    b27d0fe View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2024

  1. bug fixes

    *Fixed bug where approved decorator would not check for native token address
    *Fixed bug where _is_approved() decorator only checked for positional args and not kwargs
    RoscoeTheDog committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    0d50400 View commit details
    Browse the repository at this point in the history
Loading