Skip to content

RK-19777 - remove sentry #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sonariorobot merged 5 commits into from
Sep 27, 2023
Merged

RK-19777 - remove sentry #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ecd4e1c
remove sentry
ElDuderinos Sep 10, 2023
544c5b7
update test file
ElDuderinos Sep 10, 2023
b88b1d8
keep line numbers
ElDuderinos Sep 27, 2023
88919ba
more cleanup
ElDuderinos Sep 27, 2023
8fb85fb
update sha
ElDuderinos Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .jenkins/Jenkinsfile.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
regressionTest {
FILE_PATH = "app.py"
LINE_NUM = "114"
SHA = "27b674504743b0c2472db804da5e6e7234d8bbd4b274f3c8db2903de1e9e3bd2"
SHA = "3658556546f8bb925e5be01da38432f0a924d48f9c05bfbe0c40981dbf34ca66"
LANG = "Python"
BACKGROUND_IMAGE_CMD = "python /app/app.py &"
URL_FOR_TRIGGER = "http://localhost:5000/todos"
Expand Down
12 changes: 6 additions & 6 deletions app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,18 @@
from datetime import datetime
from random import randint
from todos_store import Store
import sentry_sdk
from sentry_sdk.integrations.flask import FlaskIntegration

@Urook Urook Sep 10, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no,
Just realized our e2es rely on things being in specific lines. So, removing lines will break e2es. Lets leave the removed lines empty insteqd of removing them?

@ElDuderinos ElDuderinos Sep 11, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do e2e with tutorial-python?

@ElDuderinos ElDuderinos Sep 27, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Urook ?

@Urook Urook Sep 27, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ElDuderinos Yes, in profiling

@ElDuderinos ElDuderinos Sep 27, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, done



from jaeger_client import Config
from flask_opentracing import FlaskTracer
from utils.logging import on_add_todo_logging, on_get_todos_logging
import os
from flask import send_from_directory

sentry_sdk.init(

@Urook Urook Sep 10, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont we need to recalculate the hash of the file?

@ElDuderinos ElDuderinos Sep 10, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true true, fixed

dsn="https://[email protected]/1381062",
integrations=[FlaskIntegration()]
)





app = flask.Flask(__name__, static_url_path='/static')

Expand Down
1 change: 0 additions & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
rook>=0.1.209
flask>=1.0,<=2.0
sentry-sdk[flask]>=0.6.9
-e git+https://github.com/Rookout/python-flask.git@e56318f9c84978ecdaeaaff4aa819dc86f5509c7#egg=Flask_OpenTracing
jaeger-client
protobuf>=3.18.3 # not directly required, pinned by Snyk to avoid a vulnerability