Skip to content

RK-7783 - favicon and clear bug #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ElDuderinos merged 1 commit into from
Nov 29, 2020
Merged

RK-7783 - favicon and clear bug #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .jenkins/Jenkinsfile.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
regressionTest {
FILE_PATH = "app.py"
LINE_NUM = "112"
SHA = "ab93bb28c989de432ea6f2c6c407f8c53f13d9cb8828ac38f3d642990df5b3b4"
LINE_NUM = "114"
SHA = "6833c3840a3542adddde98bceaa1aa715d49cf29b5295b6b3e84817a0b967129"
LANG = "Python"
BACKGROUND_IMAGE_CMD = "python /app/app.py &"
URL_FOR_TRIGGER = "http://localhost:5000/todos"
Expand Down
9 changes: 7 additions & 2 deletions app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
from jaeger_client import Config
from flask_opentracing import FlaskTracer
from utils.logging import on_add_todo_logging, on_get_todos_logging
import os
from flask import send_from_directory

sentry_sdk.init(
dsn="https://[email protected]/1381062",
Expand All @@ -37,7 +39,7 @@ def handle_exception(e):

@app.errorhandler(404)
def page_not_found(e):
rook.capture_exception(e)
rook.capture_exception(e)
return '404 Page Not Found'


Expand Down Expand Up @@ -68,7 +70,7 @@ def del_todo(todoId):

@app.route('/todos/clear_completed', methods=['DELETE'])
def clear_completed():
todos = Store.getInstance().todos
todos = Store.getInstance().all_todos
todo = [t for t in todos if not t['completed']]
return '', 204

Expand Down Expand Up @@ -126,6 +128,9 @@ def duplicate_todo(todoId):
break
return '', 204

@app.route('/favicon.ico')
def favicon():
return send_from_directory(os.path.join(app.root_path, 'static'), 'rookout_favicon.ico', mimetype='image/vnd.microsoft.icon')

def initialize_tracer():
config = Config(
Expand Down
Binary file added static/rookout_favicon.ico
View file
Open in desktop
Binary file not shown.