ENH: Add the Coriolis Acceleration #796
Description
I noticed that RocketPy currently doesn’t account for Coriolis effects in its equations.
I made a few local modifications to include this behavior and found that, for a rocket with a 3 km apogee, the deviation at the impact point is less than 10 meters.
Since these changes were minimal, I thought you might be interested in checking them out.
Let me know if you're interested!
Reacted by Gui
Activity
Gui-FernandesBR commentedon Mar 25, 2025
@kevin-alcaniz great.
Yes, please do share with us the implementation you are proposing, and also let us check with you the deviations you've mentioned
kevin-alcaniz commentedon Mar 26, 2025
Do I make a pull request??
Gui-FernandesBR commentedon Mar 26, 2025
Yes, please! Let it clear that your code is a code suggestion and we will discuss it thoroughly.
Kevin, I added you as an external collaborator to this repo, this should make it possible for you to create new branches on this repository directly (rather than on your own fork). If you agree, I'd recommend you to start opening branches on this repo directly, whenever you desire to pull request new changes. This would make the review process easier, given that the whole organization will have easier access to your branch.
In case you still want to keep pulling from your fork onto our develop branch, that's ok as well.
kevin-alcaniz commentedon Mar 27, 2025
Great!! I'm going to create the branch
kevin-alcaniz commentedon Mar 27, 2025
I've already uploaded my local branch to the repo. I'll submit the PR later, as I want to include a brief theoretical explanation to justify the changes. In the meantime, you can check it out!