Refactor execution-plan freeing mechanism - #2946
Merged
Merged
Conversation
OfirMos
force-pushed
the
fix-free-exec-plan-raz
branch
3 times, most recently
from
March 22, 2023 15:58
01d2b28 to
9c14a7d
Compare
raz-mon
commented
Mar 23, 2023
OfirMos
force-pushed
the
fix-free-exec-plan-raz
branch
from
March 23, 2023 08:35
9c14a7d to
18dbf1f
Compare
Co-authored-by: razmon <[email protected]>
OfirMos
force-pushed
the
fix-free-exec-plan-raz
branch
from
March 23, 2023 08:41
18dbf1f to
105e491
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2946 +/- ##
==========================================
+ Coverage 90.33% 90.56% +0.23%
==========================================
Files 283 282 -1
Lines 28044 27962 -82
==========================================
- Hits 25333 25324 -9
+ Misses 2711 2638 -73
... and 33 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
swilly22
suggested changes
Apr 13, 2023
swilly22
suggested changes
Apr 17, 2023
swilly22
approved these changes
Apr 17, 2023
AviAvni
added a commit
that referenced
this pull request
Apr 30, 2023
* Refactor execution-plan freeing mechanism Co-authored-by: razmon <[email protected]> * use rax to store labels * fix comments * add comment * addressing review comments * addressed review comments * fix * leak fix * free ops deepest first * addressing review comments * Update execution_plan.c remove dict init * Update execution_plan.c include setjmp * touchup * touchup --------- Co-authored-by: Ofir Moskovich <[email protected]> Co-authored-by: Avi Avni <[email protected]> Co-authored-by: Roi Lipman <[email protected]>
AviAvni
added a commit
that referenced
this pull request
Apr 30, 2023
* Effects (#2826) * update with master * wait for replica * wait after each query * refactor test * effect configuration * wip * determine when to use effects * remove stats * skip replica config * adjust constraint test * use readonly query whenever possible * debuging * pass array and len to update labels * set edge endpoints * mostly repositioning * remove debugging prints * Update graph.query.md (#3029) BFS: 3 arguments instead of 4 * Clear errno before strtol() (#3021) Co-authored-by: Roi Lipman <[email protected]> * Validate with fix (#3018) * wip * fix validations * touchup * no if branch when children are not visited * migrate and add tests, fix RETURN validation * doc addition --------- Co-authored-by: Roi Lipman <[email protected]> * Refactor execution-plan freeing mechanism (#2946) * Refactor execution-plan freeing mechanism Co-authored-by: razmon <[email protected]> * use rax to store labels * fix comments * add comment * addressing review comments * addressed review comments * fix * leak fix * free ops deepest first * addressing review comments * Update execution_plan.c remove dict init * Update execution_plan.c include setjmp * touchup * touchup --------- Co-authored-by: Ofir Moskovich <[email protected]> Co-authored-by: Avi Avni <[email protected]> Co-authored-by: Roi Lipman <[email protected]> * Fix optimize label scan (2) (#3034) * introduce swap candidates to Label-Scan * doc-fix * fix * tests fix * Update test_optimizations_plan.py * Update scan_functions.h * move context to heap * fix leak * for index scan as well * addressing review comments * touchup * Update scan_functions.c * Update scan_functions.c --------- Co-authored-by: Roi Lipman <[email protected]> * Fix LockWrite crash (#3039) * JoinConsume(): Propagaget reset if stream depleted * WIP: Test FOREACH * fix foreach crash * fix tests * fix --------- Co-authored-by: Avi Avni <[email protected]> * Fix for Xenial (OpenMP 4.0/4.5) (#3017) * Fix for Xenial (OpenMP 4.5) * fixes 1 * fixes 2 * fixes 3 * fixes 4 * fixes 5 * fixes 6 * fixes 7 --------- Co-authored-by: Avi Avni <[email protected]> * accumulate updates (#3005) * accumulate updates * fix leaks * add test * unify default dictType definitions * fix * fix 2 * add test * wip fix * wip fix * fix crash * add effect log * early review * fix build * fix test * fixes * fix * refactoring in progress * refactoring continue * write effects directly into buffer * effects-buffer * no need to clone value * no need to clone string * address review comments * address review * fix * address review comment * address reivew * fix perf issue * fix build * refactoring * fix perf * fix build * fix * fix leak * remove redundant flags * compute change against new attribute-set * fix perf * address review * fix * fix * adding comments --------- Co-authored-by: razmon <[email protected]> Co-authored-by: Raz Monsonego <[email protected]> Co-authored-by: swilly22 <[email protected]> Co-authored-by: Roi Lipman <[email protected]> * Fix rewrite `DELETE` clauses (#3067) * fix and test * add example --------- Co-authored-by: Avi Avni <[email protected]> * Reattach on reset (#3070) * formatting * reattach iterator on reset * disable graphblas memory pool (#3068) * bump version 2.12.1 --------- Co-authored-by: Roi Lipman <[email protected]> Co-authored-by: Lior Kogan <[email protected]> Co-authored-by: nafraf <[email protected]> Co-authored-by: Raz Monsonego <[email protected]> Co-authored-by: Ofir Moskovich <[email protected]> Co-authored-by: Rafi Einstein <[email protected]> Co-authored-by: razmon <[email protected]> Co-authored-by: swilly22 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the freeing mechanism of our execution-plan, and by thus allows for more complex execution-plans such as introduced in Foreach and Call {}.