Skip to content

Remove CHM check to allow reusing the Subscriber instance#159

Merged
akarnokd merged 1 commit intoReactiveX:1.xfrom
akarnokd:SubscriberExclusionFix
Nov 15, 2016
Merged

Remove CHM check to allow reusing the Subscriber instance#159
akarnokd merged 1 commit intoReactiveX:1.xfrom
akarnokd:SubscriberExclusionFix

Conversation

@akarnokd
Copy link
Copy Markdown
Member

Bump to RxJava 1.2.2

Remove the CHM that checked if someone subscribed with the same RS Subscriber instance twice. It has performance penalty and otherwise over-restrictive in some cases where the downstream reuses the same Subscriber instance in a completely safe manner.

@codecov-io
Copy link
Copy Markdown

Current coverage is 79.41% (diff: 81.81%)

Merging #159 into 1.x will increase coverage by 0.63%

@@                1.x       #159   diff @@
==========================================
  Files             8          8          
  Lines           278        272     -6   
  Methods           0          0          
  Messages          0          0          
  Branches         51         49     -2   
==========================================
- Hits            219        216     -3   
+ Misses           30         28     -2   
+ Partials         29         28     -1   

Powered by Codecov. Last update a3c326c...397a005

@akarnokd akarnokd merged commit 1c6a64d into ReactiveX:1.x Nov 15, 2016
@akarnokd akarnokd deleted the SubscriberExclusionFix branch November 15, 2016 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants